Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect JSON Format When Adding Comments to PRs #21

Closed
lrv1668 opened this issue Dec 31, 2020 · 1 comment
Closed

Incorrect JSON Format When Adding Comments to PRs #21

lrv1668 opened this issue Dec 31, 2020 · 1 comment

Comments

@lrv1668
Copy link

lrv1668 commented Dec 31, 2020 •
edited
Loading

When adding comments to a PR, this API call expects an achor key. This allows the comment to be applied to a line of a file in a diff.

As far as I can tell, CreatePullRequestCommentAsync doesn't format the JSON data with the anchor key, meaning that comments only get applied at the overview level.
@lvermeulen
Copy link
Owner

Thanks for the PR, @lrv1668 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lvermeulen @lrv1668