UTF-8 encoding properties #77

Closed
suplik10 opened this Issue May 14, 2014 · 10 comments

Comments

Projects
None yet
2 participants
@suplik10

Hi Iviggiano,
I'm very interested in your amaizing project OWNER. But now i have a problem with correctly loading properties. I need load properties with czech diacritic (like as áčďéěíňóřšťůúýž) in UTF-8 format. Properties of file names.properties are set on UTF-8 like as my Ecliplse project, but OWNER still load String Ä�Ä�éÄ�íÅ�óÅ�Å.

Can u help me ?

Thank u very much

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 19, 2014

Owner

Hi @suplik10, thanks for your appreciation and sorry for the delay with this response.

At the moment, the loading of properties is done using the default behavior of java.util.Properties, but adding UTF-8 support should not be difficult, and - I think - should be enabled by default. I'll work on this asap.

I simply didn't consider the problem before, thanks for pointing this out.

Owner

lviggiano commented May 19, 2014

Hi @suplik10, thanks for your appreciation and sorry for the delay with this response.

At the moment, the loading of properties is done using the default behavior of java.util.Properties, but adding UTF-8 support should not be difficult, and - I think - should be enabled by default. I'll work on this asap.

I simply didn't consider the problem before, thanks for pointing this out.

@lviggiano lviggiano added this to the 1.0.6 milestone May 19, 2014

@lviggiano lviggiano added bug labels May 19, 2014

@lviggiano lviggiano modified the milestone: 1.0.6 May 19, 2014

@suplik10

This comment has been minimized.

Show comment
Hide comment
@suplik10

suplik10 May 20, 2014

Thank you very much for your reply ! When it could be finished if I can ask u pls?

Thx a lot !

Thank you very much for your reply ! When it could be finished if I can ask u pls?

Thx a lot !

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 20, 2014

Owner

Hi @suplik10. No idea yet.

If you want to try to add it by yourself, here is where I'd start to look at.

It should be quite easy to implement, but I need a free evening to work on this. And recently I have been very busy.

Luigi

Owner

lviggiano commented May 20, 2014

Hi @suplik10. No idea yet.

If you want to try to add it by yourself, here is where I'd start to look at.

It should be quite easy to implement, but I need a free evening to work on this. And recently I have been very busy.

Luigi

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 20, 2014

Owner

@suplik10, in the mean time, have you tried to use the XML Loading? It should work with utf-8, but I don't have a test case for it, so I cannot assert it for sure.

Owner

lviggiano commented May 20, 2014

@suplik10, in the mean time, have you tried to use the XML Loading? It should work with utf-8, but I don't have a test case for it, so I cannot assert it for sure.

@lviggiano lviggiano closed this in 354d700 May 23, 2014

lviggiano added a commit that referenced this issue May 23, 2014

Merge pull request #78 from SvetaNesterenko/utf8-fix
 UTF-8 encoding properties. Resolves #77
@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 23, 2014

Owner

Hi @suplik10 !

@SvetaNesterenko fixed this issue. Can you try and check if your use case is working now? Do you need me to provide a packaged jar to you to ease your test?

Thanks,

Luigi.

Owner

lviggiano commented May 23, 2014

Hi @suplik10 !

@SvetaNesterenko fixed this issue. Can you try and check if your use case is working now? Do you need me to provide a packaged jar to you to ease your test?

Thanks,

Luigi.

@suplik10

This comment has been minimized.

Show comment
Hide comment
@suplik10

suplik10 May 26, 2014

Hi @lviggiano !
Thanks a lot! I using Sonatype Nexus Maven repository and there is 1.0.6-SNAPSHOT from 14.4.2014. Soo can I ask u for jar package for my test ? Thank u very much ! :-)

Hi @lviggiano !
Thanks a lot! I using Sonatype Nexus Maven repository and there is 1.0.6-SNAPSHOT from 14.4.2014. Soo can I ask u for jar package for my test ? Thank u very much ! :-)

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 26, 2014

Owner

Hi @suplik10.

I just deployed owner-1.0.6-20140526* on the snapshot repository

Owner

lviggiano commented May 26, 2014

Hi @suplik10.

I just deployed owner-1.0.6-20140526* on the snapshot repository

@suplik10

This comment has been minimized.

Show comment
Hide comment
@suplik10

suplik10 May 28, 2014

HI @lviggiano,
it works! Thank u very much !

HI @lviggiano,
it works! Thank u very much !

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 28, 2014

Owner

Thanks for verifying and thanks to @SvetaNesterenko for the fix.

@suplik10, I think I'll deploy a release (1.5.1) asap, so you won't need anymore to use the snapshot repository.

Owner

lviggiano commented May 28, 2014

Thanks for verifying and thanks to @SvetaNesterenko for the fix.

@suplik10, I think I'll deploy a release (1.5.1) asap, so you won't need anymore to use the snapshot repository.

@suplik10

This comment has been minimized.

Show comment
Hide comment
@suplik10

suplik10 May 30, 2014

Oki, ty very much again and ofc @SvetaNesterenko thanks too ! :)

Oki, ty very much again and ofc @SvetaNesterenko thanks too ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment