Add list() to ConfigCache #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigCache is a great way to centralise configuration for various parts of an application. This commit adds a list() method to the ConfigCache class, which lists the keys for all configurations present in the cache. This allows the entire application configuration to be inspected (e.g. for debugging) without the need for storing cache keys elsewhere.
|
Merged. If you like, you can write some documentation here: https://github.com/lviggiano/owner/blob/master/owner-site/site/docs/singleton.md |
|
instead of creating a new HashSet, you can return an unmodifiableSet |
|
Sounds good. I'll update the docs and switch to unmodifiableSet and submit a new pull request shortly. |
|
Do a pull before adding new commits otherwise you may have some conflicts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigCache is a great way to centralise configuration for various
parts of an application. This commit adds a list() method to the
ConfigCache class, which lists the keys for all configurations
present in the cache. This allows the entire application
configuration to be inspected (e.g. for debugging) without the need
for storing cache keys elsewhere.