-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed methodname to: PROPERTY_EDITOR.canNotUsePropertyEditors() #80
Conversation
1 similar comment
I agree, a positive form is easier to read/understand. Should this be changed too?: ``` java`
|
I would keep the method name as private boolean isPropertyEditorDisabled() {
return Boolean.getBoolean("org.aeonbits.owner.property.editor.disabled");
} I added this because on Android the PropertyEditor classes are not available, so OWNER will check if these are available in the classpath and disable it automatically. The system property instead allows this to be done by the user. It came handy for unit testing; I think it's undocumented, I should document it possibly. |
I just did a minor refactoring on Converters class, ensure to pull it from my master branch before to apply your changes. Thanks. |
Conflicts: owner/src/main/java/org/aeonbits/owner/Converters.java
1 similar comment
Changed methodname to: rectored PROPERTY_EDITOR converter (method name was wrong)
I found the method name confusing, i.e. return
null
when we "can use property editors".So I figured "canNotUsePropertyEditors" would be a less confusing name.
/Alex