fix(eslint-plugin/prefer-constraint-array-type): for characters `Iden…

…tifier`
lvjiaxuan · Oct 18, 2022 · 095ca16 · 095ca16
1 parent 01d57a6
commit 095ca16
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/prefer-constraint-array-type.test.ts b/packages/eslint-plugin/src/rules/prefer-constraint-array-type.test.ts
@@ -9,7 +9,7 @@ it('runs', () => {
   ruleTester.run(RULE_NAME, rule, {
     valid: [
       'const foo = 123\n\ntype ArrayType<T extends unknown[] = []> = [...T]',
-      // template strings
+      'const foo = 123\n\ntype ArrayType<TestArr extends unknown[] = []> = [...T]',
       'const foo = 123\n\nfunction fun<T extends number[] = []>() {\n  // ...\n}',
     ],
     invalid: [
@@ -18,6 +18,11 @@ it('runs', () => {
         output: 'const foo = 123\n\ntype ArrayType<T extends unknown[] = []> = [...T]',
         errors: [ { messageId: 'preferConstraint' } ],
       },
+      {
+        code: 'const foo = 123\n\ntype ArrayType<TestArr = []> = [...T]',
+        output: 'const foo = 123\n\ntype ArrayType<TestArr extends unknown[] = []> = [...T]',
+        errors: [ { messageId: 'preferConstraint' } ],
+      },
       {
         code: 'const foo = 123\n\nfunction fun<T = []>() {\n  // ...\n}',
         output: 'const foo = 123\n\nfunction fun<T extends unknown[] = []>() {\n  // ...\n}',

diff --git a/packages/eslint-plugin/src/rules/prefer-constraint-array-type.ts b/packages/eslint-plugin/src/rules/prefer-constraint-array-type.ts
@@ -36,7 +36,7 @@ export default createRule({
             // data:
             fix(fixer) {
               return fixer.insertTextAfterRange(
-                [ node.name.range[0] + 1, node.name.range[0] + 1 ],
+                [ node.name.range[1], node.name.range[1] ],
                 ' extends unknown[]',
               )
             },