Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to keep images on camera? #98

Closed
philipptrenz opened this issue Mar 30, 2018 · 2 comments
Closed

How to keep images on camera? #98

philipptrenz opened this issue Mar 30, 2018 · 2 comments

Comments

@philipptrenz
Copy link
Contributor

Hi @lwille,
thanks so much for your work! 馃憤

I'm currently migrating my photo booth software from executing the CLI interface to your library. Triggering the CLI and writing the images to the file system was the best way for me to go in 2016 馃槄
The only thing I couldn't find was a way to keep the images on the camera. I selected the capturetarget properly, but they won't stay on the sd card like they do with gphoto2 --capture-image-and-download --keep.

Did I miss anything?

@philipptrenz
Copy link
Contributor Author

Ah, found it in camera_helpers.cc, line 380. So it's a feature request.
I think the best way to go is to add bool keep to take_picture_request and check before deleting. Maybe you want to take a look? Otherwise I'll try, but I'm quite inexperienced with bindings to JavaScript.

@lwille
Copy link
Owner

lwille commented Mar 30, 2018

Just give it a shot, I don鈥檛 have a camera to test. If you create a PR I鈥檇 happily review your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants