Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about a Flatpak version on FlatHub ? #804

Closed
antistress opened this issue Mar 28, 2020 · 9 comments
Closed

How about a Flatpak version on FlatHub ? #804

antistress opened this issue Mar 28, 2020 · 9 comments
Milestone

Comments

@antistress
Copy link

Hi,
I see that 1.12.5 version says "Added flatpak JSON"
I'd love to get a flatpak version of Liferea
Are there any plans to have Liferea on FlatHub ?
https://github.com/flathub/flathub/wiki/App-Submission

Thanks for Liferea, great piece of software :)

@grdryn
Copy link

grdryn commented Apr 11, 2020

+1, I came here to find out the same thing. 🙂

Nice that there's at least a manifest...I'll try that locally for now, but having it available from a registry such as flathub would be awesome.

Thanks for Liferea, great piece of software :)

Also this ☝️

@lwindolf
Copy link
Owner

I sadly do not have enough time for Liferea right now. Flatpack would just be another maintenance task that is missing time :-(

Would be great if someone could maintain such a package. The existing flatpack descriptor was contributed a while ago.

@mikelolasagasti
Copy link
Contributor

mikelolasagasti commented Oct 4, 2020

flathub/flathub#1872

A couple of simple patches are needed, will submit them later. I tested with a build from master and is working fine for me. Build can be installed with:

$ flatpak install --user https://dl.flathub.org/build-repo/28241/net.sourceforge.liferea.flatpakref

@mikelolasagasti
Copy link
Contributor

Flatpak has been published in Flathub:

https://flathub.org/apps/details/net.sourceforge.liferea

@mikelolasagasti
Copy link
Contributor

@lwindolf I think this issue can be closed as Liferea is available at FlatHub now

@lwindolf lwindolf modified the milestones: 1.13.4, 1.13.3 Oct 10, 2020
@antistress
Copy link
Author

Hi,
Thank you so much for it !
I took the time to install it and to do some tests
Here's the bug I found : #897

@nekohayo
Copy link
Contributor

Hi @mikelolasagasti ; just a theoretical nitpick... is using net.sourceforge.liferea the right namespace to use considering it's no longer been on Sourceforge (thankfully) for years? Maybe com.github etc. would be better, or de.lzone (reflecting the fact that the website itself is https://lzone.de/liferea/ )?

Speaking of website, once the question above is decided, @lwindolf would you like to advertise the Flathub Flatpak into https://lzone.de/liferea/install.htm next to the Snap package?

@mikelolasagasti
Copy link
Contributor

Hi @mikelolasagasti ; just a theoretical nitpick... is using net.sourceforge.liferea the right namespace to use considering it's no longer been on Sourceforge (thankfully) for years? Maybe com.github etc. would be better, or de.lzone (reflecting the fact that the website itself is https://lzone.de/liferea/ )?

I followed the naming of AppData, GSettings or Desktop file. It can be changed of course and I can create a PR for that, but would require @lwindolf to accept it. So, Lars, what's your opinion on this?

@lwindolf
Copy link
Owner

@nekohayo Flatpak install instructions added on website.

I also dislike the legacy net.sf.liferea namespace. The problem is how tightly it is linked into the application identity especially concerning DBUS (documented API), dconf (would require active migration) and binary formats as Flatpak. I fear the effort and support work caused by this without any user facing benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants