/
patches.go
774 lines (641 loc) · 23.1 KB
/
patches.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
package main
import (
"context"
"errors"
"fmt"
"os"
"path/filepath"
"strings"
"time"
"github.com/lxc/lxd/lxd/backup"
"github.com/lxc/lxd/lxd/cluster"
"github.com/lxc/lxd/lxd/db"
dbCluster "github.com/lxc/lxd/lxd/db/cluster"
"github.com/lxc/lxd/lxd/db/query"
"github.com/lxc/lxd/lxd/instance/instancetype"
"github.com/lxc/lxd/lxd/network"
"github.com/lxc/lxd/lxd/node"
"github.com/lxc/lxd/lxd/project"
"github.com/lxc/lxd/lxd/revert"
storagePools "github.com/lxc/lxd/lxd/storage"
"github.com/lxc/lxd/lxd/util"
"github.com/lxc/lxd/shared"
"github.com/lxc/lxd/shared/api"
"github.com/lxc/lxd/shared/logger"
)
type patchStage int
// Define the stages that patches can run at.
const (
patchNoStageSet patchStage = iota
patchPreDaemonStorage
patchPostDaemonStorage
patchPostNetworks
)
/*
Patches are one-time actions that are sometimes needed to update
existing container configuration or move things around on the
filesystem.
Those patches are applied at startup time after the database schema
has been fully updated. Patches can therefore assume a working database.
At the time the patches are applied, the containers aren't started
yet and the daemon isn't listening to requests.
DO NOT use this mechanism for database update. Schema updates must be
done through the separate schema update mechanism.
Only append to the patches list, never remove entries and never re-order them.
*/
var patches = []patch{
{name: "storage_lvm_skipactivation", stage: patchPostDaemonStorage, run: patchGenericStorage},
{name: "clustering_drop_database_role", stage: patchPostDaemonStorage, run: patchClusteringDropDatabaseRole},
{name: "network_clear_bridge_volatile_hwaddr", stage: patchPostDaemonStorage, run: patchGenericNetwork(patchNetworkClearBridgeVolatileHwaddr)},
{name: "move_backups_instances", stage: patchPostDaemonStorage, run: patchMoveBackupsInstances},
{name: "network_ovn_enable_nat", stage: patchPostDaemonStorage, run: patchGenericNetwork(patchNetworkOVNEnableNAT)},
{name: "network_ovn_remove_routes", stage: patchPostDaemonStorage, run: patchGenericNetwork(patchNetworkOVNRemoveRoutes)},
{name: "network_fan_enable_nat", stage: patchPostDaemonStorage, run: patchGenericNetwork(patchNetworkFANEnableNAT)},
{name: "thinpool_typo_fix", stage: patchPostDaemonStorage, run: patchThinpoolTypoFix},
{name: "vm_rename_uuid_key", stage: patchPostDaemonStorage, run: patchVMRenameUUIDKey},
{name: "db_nodes_autoinc", stage: patchPreDaemonStorage, run: patchDBNodesAutoInc},
{name: "network_acl_remove_defaults", stage: patchPostDaemonStorage, run: patchGenericNetwork(patchNetworkACLRemoveDefaults)},
{name: "clustering_server_cert_trust", stage: patchPreDaemonStorage, run: patchClusteringServerCertTrust},
{name: "warnings_remove_empty_node", stage: patchPostDaemonStorage, run: patchRemoveWarningsWithEmptyNode},
{name: "dnsmasq_entries_include_device_name", stage: patchPostDaemonStorage, run: patchDnsmasqEntriesIncludeDeviceName},
{name: "storage_missing_snapshot_records", stage: patchPostDaemonStorage, run: patchGenericStorage},
{name: "storage_delete_old_snapshot_records", stage: patchPostDaemonStorage, run: patchGenericStorage},
{name: "storage_zfs_drop_block_volume_filesystem_extension", stage: patchPostDaemonStorage, run: patchGenericStorage},
{name: "storage_prefix_bucket_names_with_project", stage: patchPostDaemonStorage, run: patchGenericStorage},
}
type patch struct {
name string
stage patchStage
run func(name string, d *Daemon) error
}
func (p *patch) apply(d *Daemon) error {
logger.Info("Applying patch", logger.Ctx{"name": p.name})
err := p.run(p.name, d)
if err != nil {
return fmt.Errorf("Failed applying patch %q: %w", p.name, err)
}
err = d.db.Node.MarkPatchAsApplied(p.name)
if err != nil {
return fmt.Errorf("Failed marking patch applied %q: %w", p.name, err)
}
return nil
}
// Return the names of all available patches.
func patchesGetNames() []string {
names := make([]string, len(patches))
for i, patch := range patches {
if patch.stage == patchNoStageSet {
continue // Ignore any patch without explicitly set stage (it is defined incorrectly).
}
names[i] = patch.name
}
return names
}
// patchesApplyPostDaemonStorage applies the patches that need to run after the daemon storage is initialised.
func patchesApply(d *Daemon, stage patchStage) error {
appliedPatches, err := d.db.Node.GetAppliedPatches()
if err != nil {
return err
}
for _, patch := range patches {
if patch.stage == patchNoStageSet {
return fmt.Errorf("Patch %q has no stage set: %d", patch.name, patch.stage)
}
if shared.StringInSlice(patch.name, appliedPatches) {
continue
}
err := patch.apply(d)
if err != nil {
return err
}
}
return nil
}
// Patches begin here
func patchDnsmasqEntriesIncludeDeviceName(name string, d *Daemon) error {
err := network.UpdateDNSMasqStatic(d.State(), "")
if err != nil {
return err
}
return nil
}
func patchRemoveWarningsWithEmptyNode(name string, d *Daemon) error {
err := d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
warnings, err := dbCluster.GetWarnings(ctx, tx.Tx())
if err != nil {
return err
}
for _, w := range warnings {
if w.Node == "" {
err = dbCluster.DeleteWarning(ctx, tx.Tx(), w.UUID)
if err != nil {
return err
}
}
}
return nil
})
if err != nil {
return err
}
return nil
}
func patchClusteringServerCertTrust(name string, d *Daemon) error {
clustered, err := cluster.Enabled(d.db.Node)
if err != nil {
return err
}
if !clustered {
return nil
}
var serverName string
err = d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
serverName, err = tx.GetLocalNodeName(ctx)
return err
})
if err != nil {
return err
}
// Add our server cert to DB trust store.
serverCert, err := util.LoadServerCert(d.os.VarDir)
if err != nil {
return err
}
// Update our own entry in the nodes table.
logger.Infof("Adding local server certificate to global trust store for %q patch", name)
err = d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
return cluster.EnsureServerCertificateTrusted(serverName, serverCert, tx)
})
if err != nil {
return err
}
logger.Infof("Added local server certificate to global trust store for %q patch", name)
// Check all other members have done the same.
for {
var err error
var dbCerts []dbCluster.Certificate
err = d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
dbCerts, err = dbCluster.GetCertificates(ctx, tx.Tx())
return err
})
if err != nil {
return err
}
trustedServerCerts := make(map[string]*dbCluster.Certificate)
for _, c := range dbCerts {
if c.Type == dbCluster.CertificateTypeServer {
trustedServerCerts[c.Name] = &c
}
}
var members []db.NodeInfo
err = d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
members, err = tx.GetNodes(ctx)
if err != nil {
return fmt.Errorf("Failed getting cluster members: %w", err)
}
return nil
})
if err != nil {
return err
}
missingCerts := false
for _, member := range members {
_, found := trustedServerCerts[member.Name]
if !found {
logger.Warnf("Missing trusted server certificate for cluster member %q", member.Name)
missingCerts = true
break
}
}
if missingCerts {
logger.Warnf("Waiting for %q patch to be applied on all cluster members", name)
time.Sleep(time.Second)
continue
}
logger.Infof("Trusted server certificates found in trust store for all cluster members")
break
}
// Now switch to using our server certificate for intra-cluster communication and load the trusted server
// certificates for the other members into the in-memory trusted cache.
logger.Infof("Set client certificate to server certificate %v", serverCert.Fingerprint())
d.serverCertInt = serverCert
updateCertificateCache(d)
return nil
}
// patchNetworkACLRemoveDefaults removes the "default.action" and "default.logged" settings from network ACLs.
// It was decided that the user experience of having the default actions at the ACL level was confusing when using
// multiple ACLs, and that the interplay between conflicting default actions on multiple ACLs was difficult to
// understand. Instead it will be replace with a network and NIC level defaults settings.
func patchNetworkACLRemoveDefaults(name string, d *Daemon) error {
var err error
var projectNames []string
// Get projects.
err = d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
projectNames, err = dbCluster.GetProjectNames(ctx, tx.Tx())
return err
})
if err != nil {
return err
}
// Get ACLs in projects.
for _, projectName := range projectNames {
aclNames, err := d.db.Cluster.GetNetworkACLs(projectName)
if err != nil {
return err
}
for _, aclName := range aclNames {
aclID, acl, err := d.db.Cluster.GetNetworkACL(projectName, aclName)
if err != nil {
return err
}
modified := false
// Remove the offending keys if found.
_, found := acl.Config["default.action"]
if found {
delete(acl.Config, "default.action")
modified = true
}
_, found = acl.Config["default.logged"]
if found {
delete(acl.Config, "default.logged")
modified = true
}
// Write back modified config if needed.
if modified {
err = d.db.Cluster.UpdateNetworkACL(aclID, &acl.NetworkACLPut)
if err != nil {
return fmt.Errorf("Failed updating network ACL %d: %w", aclID, err)
}
}
}
}
return nil
}
// patchDBNodesAutoInc re-creates the nodes table id column as AUTOINCREMENT.
// Its done as a patch rather than a schema update so we can use PRAGMA foreign_keys = OFF without a transaction.
func patchDBNodesAutoInc(name string, d *Daemon) error {
for {
// Only apply patch if schema needs it.
var schemaSQL string
row := d.State().DB.Cluster.DB().QueryRow("SELECT sql FROM sqlite_master WHERE name = 'nodes'")
err := row.Scan(&schemaSQL)
if err != nil {
return err
}
if strings.Contains(schemaSQL, "id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL") {
logger.Debugf(`Skipping %q patch as "nodes" table id column already AUTOINCREMENT`, name)
return nil // Nothing to do.
}
// Only apply patch on leader, otherwise wait for it to be applied.
var localConfig *node.Config
err = d.db.Node.Transaction(context.TODO(), func(ctx context.Context, tx *db.NodeTx) error {
localConfig, err = node.ConfigLoad(ctx, tx)
return err
})
if err != nil {
return err
}
leaderAddress, err := d.gateway.LeaderAddress()
if err != nil {
if errors.Is(err, cluster.ErrNodeIsNotClustered) {
break // Apply change on standalone node.
}
return err
}
if localConfig.ClusterAddress() == leaderAddress {
break // Apply change on leader node.
}
logger.Warnf("Waiting for %q patch to be applied on leader cluster member", name)
time.Sleep(time.Second)
}
// Apply patch.
_, err := d.State().DB.Cluster.DB().Exec(`
PRAGMA foreign_keys=OFF; -- So that integrity doesn't get in the way for now.
PRAGMA legacy_alter_table = ON; -- So that views referencing this table don't block change.
CREATE TABLE nodes_new (
id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
name TEXT NOT NULL,
description TEXT DEFAULT '',
address TEXT NOT NULL,
schema INTEGER NOT NULL,
api_extensions INTEGER NOT NULL,
heartbeat DATETIME DEFAULT CURRENT_TIMESTAMP,
state INTEGER NOT NULL DEFAULT 0,
arch INTEGER NOT NULL DEFAULT 0 CHECK (arch > 0),
failure_domain_id INTEGER DEFAULT NULL REFERENCES nodes_failure_domains (id) ON DELETE SET NULL,
UNIQUE (name),
UNIQUE (address)
);
INSERT INTO nodes_new (id, name, description, address, schema, api_extensions, heartbeat, state, arch, failure_domain_id)
SELECT id, name, description, address, schema, api_extensions, heartbeat, state, arch, failure_domain_id FROM nodes;
DROP TABLE nodes;
ALTER TABLE nodes_new RENAME TO nodes;
PRAGMA foreign_keys=ON; -- Make sure we turn integrity checks back on.
PRAGMA legacy_alter_table = OFF; -- So views check integrity again.
`)
return err
}
// patchVMRenameUUIDKey renames the volatile.vm.uuid key to volatile.uuid in instance and snapshot configs.
func patchVMRenameUUIDKey(name string, d *Daemon) error {
oldUUIDKey := "volatile.vm.uuid"
newUUIDKey := "volatile.uuid"
return d.State().DB.Cluster.InstanceList(context.TODO(), func(inst db.InstanceArgs, p api.Project) error {
if inst.Type != instancetype.VM {
return nil
}
return d.State().DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
uuid := inst.Config[oldUUIDKey]
if uuid != "" {
changes := map[string]string{
oldUUIDKey: "",
newUUIDKey: uuid,
}
logger.Debugf("Renaming config key %q to %q for VM %q (Project %q)", oldUUIDKey, newUUIDKey, inst.Name, inst.Project)
err := tx.UpdateInstanceConfig(inst.ID, changes)
if err != nil {
return fmt.Errorf("Failed renaming config key %q to %q for VM %q (Project %q): %w", oldUUIDKey, newUUIDKey, inst.Name, inst.Project, err)
}
}
snaps, err := tx.GetInstanceSnapshotsWithName(ctx, inst.Project, inst.Name)
if err != nil {
return err
}
for _, snap := range snaps {
config, err := dbCluster.GetInstanceConfig(ctx, tx.Tx(), snap.ID)
if err != nil {
return err
}
uuid := config[oldUUIDKey]
if uuid != "" {
changes := map[string]string{
oldUUIDKey: "",
newUUIDKey: uuid,
}
logger.Debugf("Renaming config key %q to %q for VM %q (Project %q)", oldUUIDKey, newUUIDKey, snap.Name, snap.Project)
err = tx.UpdateInstanceSnapshotConfig(snap.ID, changes)
if err != nil {
return fmt.Errorf("Failed renaming config key %q to %q for VM %q (Project %q): %w", oldUUIDKey, newUUIDKey, snap.Name, snap.Project, err)
}
}
}
return nil
})
})
}
// patchThinpoolTypoFix renames any config incorrectly set config file entries due to the lvm.thinpool_name typo.
func patchThinpoolTypoFix(name string, d *Daemon) error {
revert := revert.New()
defer revert.Fail()
// Setup a transaction.
tx, err := d.db.Cluster.Begin()
if err != nil {
return fmt.Errorf("Failed to begin transaction: %w", err)
}
revert.Add(func() { _ = tx.Rollback() })
// Fetch the IDs of all existing nodes.
nodeIDs, err := query.SelectIntegers(context.TODO(), tx, "SELECT id FROM nodes")
if err != nil {
return fmt.Errorf("Failed to get IDs of current nodes: %w", err)
}
// Fetch the IDs of all existing lvm pools.
poolIDs, err := query.SelectIntegers(context.TODO(), tx, "SELECT id FROM storage_pools WHERE driver='lvm'")
if err != nil {
return fmt.Errorf("Failed to get IDs of current lvm pools: %w", err)
}
for _, poolID := range poolIDs {
// Fetch the config for this lvm pool and check if it has the lvm.thinpool_name.
config, err := query.SelectConfig(context.TODO(), tx, "storage_pools_config", "storage_pool_id=? AND node_id IS NULL", poolID)
if err != nil {
return fmt.Errorf("Failed to fetch of lvm pool config: %w", err)
}
value, ok := config["lvm.thinpool_name"]
if !ok {
continue
}
// Delete the current key
_, err = tx.Exec(`
DELETE FROM storage_pools_config WHERE key='lvm.thinpool_name' AND storage_pool_id=? AND node_id IS NULL
`, poolID)
if err != nil {
return fmt.Errorf("Failed to delete lvm.thinpool_name config: %w", err)
}
// Add the config entry for each node
for _, nodeID := range nodeIDs {
_, err := tx.Exec(`
INSERT INTO storage_pools_config(storage_pool_id, node_id, key, value)
VALUES(?, ?, 'lvm.thinpool_name', ?)
`, poolID, nodeID, value)
if err != nil {
return fmt.Errorf("Failed to create lvm.thinpool_name node config: %w", err)
}
}
}
err = tx.Commit()
if err != nil {
return fmt.Errorf("Failed to commit transaction: %w", err)
}
revert.Success()
return nil
}
// patchNetworkFANEnableNAT sets "ipv4.nat=true" on fan bridges that are missing the "ipv4.nat" setting.
// This prevents outbound connectivity breaking on existing fan networks now that the default behaviour of not
// having "ipv4.nat" set is to disable NAT (bringing in line with the non-fan bridge behavior and docs).
func patchNetworkFANEnableNAT(name string, d *Daemon) error {
err := d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
projectNetworks, err := tx.GetCreatedNetworks(ctx)
if err != nil {
return err
}
for _, networks := range projectNetworks {
for networkID, network := range networks {
if network.Type != "bridge" {
continue
}
if network.Config["bridge.mode"] != "fan" {
continue
}
modified := false
// Enable ipv4.nat if setting not specified.
_, found := network.Config["ipv4.nat"]
if !found {
modified = true
network.Config["ipv4.nat"] = "true"
}
if modified {
err = tx.UpdateNetwork(networkID, network.Description, network.Config)
if err != nil {
return fmt.Errorf("Failed setting ipv4.nat=true for fan network %q (%d): %w", network.Name, networkID, err)
}
logger.Debugf("Set ipv4.nat=true for fan network %q (%d)", network.Name, networkID)
}
}
}
return nil
})
if err != nil {
return err
}
return nil
}
// patchNetworkOVNRemoveRoutes removes the "ipv4.routes.external" and "ipv6.routes.external" settings from OVN
// networks. It was decided that the OVN NIC level equivalent settings were sufficient.
func patchNetworkOVNRemoveRoutes(name string, d *Daemon) error {
err := d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
projectNetworks, err := tx.GetCreatedNetworks(ctx)
if err != nil {
return err
}
for _, networks := range projectNetworks {
for networkID, network := range networks {
if network.Type != "ovn" {
continue
}
modified := false
// Ensure existing behaviour of having NAT enabled if IP address was set.
_, found := network.Config["ipv4.routes.external"]
if found {
modified = true
delete(network.Config, "ipv4.routes.external")
}
_, found = network.Config["ipv6.routes.external"]
if found {
modified = true
delete(network.Config, "ipv6.routes.external")
}
if modified {
err = tx.UpdateNetwork(networkID, network.Description, network.Config)
if err != nil {
return fmt.Errorf("Failed removing OVN external route settings for %q (%d): %w", network.Name, networkID, err)
}
logger.Debugf("Removing external route settings for OVN network %q (%d)", network.Name, networkID)
}
}
}
return nil
})
if err != nil {
return err
}
return nil
}
// patchNetworkOVNEnableNAT adds "ipv4.nat" and "ipv6.nat" keys set to "true" to OVN networks if not present.
// This is to ensure existing networks retain the old behaviour of always having NAT enabled as we introduce
// the new NAT settings which default to disabled if not specified.
// patchNetworkCearBridgeVolatileHwaddr removes the unsupported `volatile.bridge.hwaddr` config key from networks.
func patchNetworkOVNEnableNAT(name string, d *Daemon) error {
err := d.db.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
projectNetworks, err := tx.GetCreatedNetworks(ctx)
if err != nil {
return err
}
for _, networks := range projectNetworks {
for networkID, network := range networks {
if network.Type != "ovn" {
continue
}
modified := false
// Ensure existing behaviour of having NAT enabled if IP address was set.
if network.Config["ipv4.address"] != "" && network.Config["ipv4.nat"] == "" {
modified = true
network.Config["ipv4.nat"] = "true"
}
if network.Config["ipv6.address"] != "" && network.Config["ipv6.nat"] == "" {
modified = true
network.Config["ipv6.nat"] = "true"
}
if modified {
err = tx.UpdateNetwork(networkID, network.Description, network.Config)
if err != nil {
return fmt.Errorf("Failed saving OVN NAT settings for %q (%d): %w", network.Name, networkID, err)
}
logger.Debugf("Enabling NAT for OVN network %q (%d)", network.Name, networkID)
}
}
}
return nil
})
if err != nil {
return err
}
return nil
}
// Moves backups from shared.VarPath("backups") to shared.VarPath("backups", "instances").
func patchMoveBackupsInstances(name string, d *Daemon) error {
if !shared.PathExists(shared.VarPath("backups")) {
return nil // Nothing to do, no backups directory.
}
backupsPath := shared.VarPath("backups", "instances")
err := os.MkdirAll(backupsPath, 0700)
if err != nil {
return fmt.Errorf("Failed creating instances backup directory %q: %w", backupsPath, err)
}
backups, err := os.ReadDir(shared.VarPath("backups"))
if err != nil {
return fmt.Errorf("Failed listing existing backup directory %q: %w", shared.VarPath("backups"), err)
}
for _, backupDir := range backups {
if backupDir.Name() == "instances" || strings.HasPrefix(backupDir.Name(), backup.WorkingDirPrefix) {
continue // Don't try and move our new instances directory or temporary directories.
}
oldPath := shared.VarPath("backups", backupDir.Name())
newPath := filepath.Join(backupsPath, backupDir.Name())
logger.Debugf("Moving backup from %q to %q", oldPath, newPath)
err = os.Rename(oldPath, newPath)
if err != nil {
return fmt.Errorf("Failed moving backup from %q to %q: %w", oldPath, newPath, err)
}
}
return nil
}
func patchGenericStorage(name string, d *Daemon) error {
return storagePools.Patch(d.State(), name)
}
func patchGenericNetwork(f func(name string, d *Daemon) error) func(name string, d *Daemon) error {
return func(name string, d *Daemon) error {
err := network.PatchPreCheck()
if err != nil {
return err
}
return f(name, d)
}
}
func patchClusteringDropDatabaseRole(name string, d *Daemon) error {
return d.State().DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
members, err := tx.GetNodes(ctx)
if err != nil {
return fmt.Errorf("Failed getting cluster members: %w", err)
}
for _, member := range members {
err := tx.UpdateNodeRoles(member.ID, nil)
if err != nil {
return err
}
}
return nil
})
}
// patchNetworkClearBridgeVolatileHwaddr removes the unsupported `volatile.bridge.hwaddr` config key from networks.
func patchNetworkClearBridgeVolatileHwaddr(name string, d *Daemon) error {
// Use project.Default, as bridge networks don't support projects.
projectName := project.Default
// Get the list of networks.
networks, err := d.db.Cluster.GetNetworks(projectName)
if err != nil {
return fmt.Errorf("Failed loading networks for network_clear_bridge_volatile_hwaddr patch: %w", err)
}
for _, networkName := range networks {
_, net, _, err := d.db.Cluster.GetNetworkInAnyState(projectName, networkName)
if err != nil {
return fmt.Errorf("Failed loading network %q for network_clear_bridge_volatile_hwaddr patch: %w", networkName, err)
}
if net.Config["volatile.bridge.hwaddr"] != "" {
delete(net.Config, "volatile.bridge.hwaddr")
err = d.db.Cluster.UpdateNetwork(projectName, net.Name, net.Description, net.Config)
if err != nil {
return fmt.Errorf("Failed updating network %q for network_clear_bridge_volatile_hwaddr patch: %w", networkName, err)
}
}
}
return nil
}
// Patches end here