test_networks: Avoid triggering volatile.bridge.hwaddr #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LXD now generates a stable MAC address for networks. This is placed in volatile.bridge.hwaddr unless the network has a pre-configured address. This makes the current network test fail as it assumes that the config returned after creation will be identical to that provided during creation. There are two ways of fixing this: - Strip all volatile keys - Provide a pre-set bridge.hwaddr key This implements the latter. Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 96.46% 96.10% -0.37%
==========================================
Files 17 17
Lines 1103 1103
Branches 129 129
==========================================
- Hits 1064 1060 -4
- Misses 18 20 +2
- Partials 21 23 +2
Continue to review full report at Codecov.
|
|
Merging to unbreak jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LXD now generates a stable MAC address for networks.
This is placed in volatile.bridge.hwaddr unless the network has a
pre-configured address.
This makes the current network test fail as it assumes that the config
returned after creation will be identical to that provided during
creation.
There are two ways of fixing this:
This implements the latter.
Signed-off-by: Stéphane Graber stgraber@ubuntu.com