Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shortcuts config fom /etc/xdg/lxqt to /usr/share/lxqt #60

Merged
merged 2 commits into from Aug 3, 2019

Conversation

agaida
Copy link
Member

@agaida agaida commented Nov 29, 2017

same as for session: make it easy for distributions to provide own configurations

@tsimonq2
Copy link
Member

👍

Copy link
Contributor

@palinek palinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't enough and actually breaks things in the daemon, because nothing in the globalkeys daemon can be done "normally" 👎

Check it here:

@agaida
Copy link
Member Author

agaida commented Nov 29, 2017

cool, hard coded ...

@agaida agaida changed the title move shortcuts config fom /etc/xdg/lxqt to /usr/share/lxqt WIP: move shortcuts config fom /etc/xdg/lxqt to /usr/share/lxqt Dec 12, 2017
@agaida agaida added the blocked label Dec 12, 2017
@agaida agaida self-assigned this Dec 12, 2017
@agaida agaida added this to Tests/WIP/Rework in Pull Requests Mar 27, 2018
@agaida agaida added this to Low priority in Issues Jul 14, 2018
@agaida agaida removed this from Low priority in Issues Jul 14, 2018
@agaida agaida moved this from Tests/WIP/Rework to WIP/Rework in Pull Requests Jul 14, 2018
@agaida agaida added this to To do in PRs Nov 4, 2018
@wxl
Copy link
Member

wxl commented Jul 5, 2019

I just stumbled across this one as I can see that globalkeys doesn't respect XDG variables, which is really problematic. That said, I'm not sure I quite understand what the problem is @palinek. Are you simply saying we need to provide handling for configFiles so that if no specific file is passed on the command line, then the config is grabbed from the XDG variables (which is not yet done), finally falling through to DEFAULT_CONFIG (as is currently done)?

@palinek
Copy link
Contributor

palinek commented Jul 8, 2019

I'm not sure I quite understand what the problem

The problem is the mess in the daemon code. Here the self-implementation of config files search hierarchy.

@wxl
Copy link
Member

wxl commented Jul 8, 2019

I guess what I'm asking is what can we do to fix it?

@palinek
Copy link
Contributor

palinek commented Jul 9, 2019

I guess what I'm asking is what can we do to fix it?

Now "just" review & test #123

Copy link
Contributor

@palinek palinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@agaida agaida merged commit bd9cb26 into master Aug 3, 2019
Pull Requests automation moved this from WIP/Rework to Done Aug 3, 2019
PRs automation moved this from To do to Done Aug 3, 2019
@agaida agaida deleted the xdg-config branch August 3, 2019 11:48
@agaida agaida moved this from Done to Changelog in PRs Oct 9, 2019
@agaida agaida changed the title WIP: move shortcuts config fom /etc/xdg/lxqt to /usr/share/lxqt Move shortcuts config fom /etc/xdg/lxqt to /usr/share/lxqt Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PRs
Changelog
Pull Requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants