New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super keys #62
Super keys #62
Conversation
@ska67 - would you be so kind and rebase? |
The event loop responds to KeyPress and KeyRelease events.
Register the single left or right meta key for shortcuts. Use the symbol name of the X11 system.
The left and right meta keys can trigger shortcuts at the KeyRelease event.
rebase done |
GTM - we should merge it as is, even it this feature might need a little bit improvement in future. Work ok for me. |
@agaida Sorry that I didn't find time to look into it! |
I suspect that this feature need a little bit love in the future - but it works and we will see when it falls short - with a broader audience maybe in more cases as we thought. And i guess thats a good thing. |
@agaida I completely agree. |
I'm also sorry, but don't have the time for this.....but again... the codebase of lxqt-globalkeysd is a mess and I believe, we should drop it and use kglobalaccel. |
Using kwindowsystem is one thing, using kglobalaccel is another. Getting dependent on more and more KDE-related code is very bad, IMO. lxqt-globalkeys has worked here for a long time. It's better to clean up its code instead of throwing it away. |
This is the solution 1.2. which I described in issue lxqt/lxqt#1259 on 3.12.2017.
This solution required the least changes in the source code.
You can merge the source code as it is. However, if you prefer a different name for the meta keys, e. g."meta-left" and "meta-right" instead of the X11 symbol names, then I can make the changes before merging.