Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super keys #62

Merged
merged 4 commits into from Jan 16, 2018
Merged

Super keys #62

merged 4 commits into from Jan 16, 2018

Conversation

ska67
Copy link
Contributor

@ska67 ska67 commented Dec 10, 2017

This is the solution 1.2. which I described in issue lxqt/lxqt#1259 on 3.12.2017.
This solution required the least changes in the source code.

You can merge the source code as it is. However, if you prefer a different name for the meta keys, e. g."meta-left" and "meta-right" instead of the X11 symbol names, then I can make the changes before merging.

@agaida
Copy link
Member

agaida commented Jan 13, 2018

@ska67 - would you be so kind and rebase?

The event loop responds to KeyPress and KeyRelease events.
Register the single left or right meta key for shortcuts.
Use the symbol name of the X11 system.
The left and right meta keys can trigger shortcuts
at the KeyRelease event.
@ska67
Copy link
Contributor Author

ska67 commented Jan 14, 2018

rebase done

@agaida
Copy link
Member

agaida commented Jan 14, 2018

GTM - we should merge it as is, even it this feature might need a little bit improvement in future. Work ok for me.
@tsujan @palinek @luis-pereira - what do you think?

@agaida agaida merged commit fc35a3b into lxqt:master Jan 16, 2018
@tsujan
Copy link
Member

tsujan commented Jan 16, 2018

@agaida Sorry that I didn't find time to look into it!

@ska67 ska67 deleted the super-keys branch January 16, 2018 18:50
@agaida
Copy link
Member

agaida commented Jan 16, 2018

I suspect that this feature need a little bit love in the future - but it works and we will see when it falls short - with a broader audience maybe in more cases as we thought. And i guess thats a good thing.

@tsujan
Copy link
Member

tsujan commented Jan 16, 2018

@agaida I completely agree.

@palinek
Copy link
Contributor

palinek commented Jan 17, 2018

I'm also sorry, but don't have the time for this.....but again... the codebase of lxqt-globalkeysd is a mess and I believe, we should drop it and use kglobalaccel.

@tsujan
Copy link
Member

tsujan commented Jan 17, 2018

the codebase of lxqt-globalkeysd is a mess and I believe, we should drop it and use kglobalaccel.

Using kwindowsystem is one thing, using kglobalaccel is another. Getting dependent on more and more KDE-related code is very bad, IMO. lxqt-globalkeys has worked here for a long time. It's better to clean up its code instead of throwing it away.

@agaida agaida added this to Done in Pull Requests Mar 27, 2018
@agaida agaida added this to Done in PRs Nov 4, 2018
@agaida agaida moved this from Done to Archive in PRs Nov 27, 2018
@agaida agaida added this to Old Archive in Pull Requests Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PRs
Changelog
Pull Requests
  
Old Archive (fucked up)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants