Using the new XdgIconLoaderEngine, Qt4 status notifier items have no icon

[paulolieuthier]

sni-qt turns Qt4's QSystemTray items into StatusNotiferItems. After the new XdgIconLoaderEngine addition to our Qt plugin (lxqt/lxqt-qtplugin#10), those icons are no longer visible.

This is what happens (AFAIK):

• lxqt-panel asks the application for a icon name, and then asks QIcon for that icon (source).
• QIcon creates the icon through our engine (source).
• XdgIconLoaderEngine can't find sni-qt powered icons, because those are in private, custom folders.
• Somehow the QIcon instance created is valid (source) and lxqt-panel won't search for the icons in the custom theme folders because it thinks the icons were found in the system theme.

This needs to be fixed in the current milestone.

[paulolieuthier]

The weird thing is that I (still) don't see any difference between XdgIconLoaderEngine and QIconLoaderEngine.

[tsujan]

If that's the case, it should be fixed before the next release, IMHO. Sorry that I can't help (I didn't have time to try XdgIconLoaderEngine and still use my old trick lxqt/lxqt-qtplugin#9). I may be totally lost asking this but how could a Qt5 icon loader affect Qt4 apps? Here, without XdgIconLoaderEngine, I see Skype's icon among status notifier items.

[paulolieuthier]

Well, that's actually a good question. I think that's because lxqt-panel is the one using XdgIconLoaderEngine, and the Qt4 apps are using the StatusNotifierItem protocol.

[paulolieuthier]

The way I see it, the problem is not about Qt4, or the SNI protocol. It's about the icon loader engine stating that it found icons that it didn't find.

[luis-pereira]

@paulolieuthier Can you give me an example ?

[paulolieuthier]

KeePassX and MEGASync.

[luis-pereira]

KeePassX is working for me

[stefonarch]

Keepassx works too here, but appset-qt is not visible, was always wondering why. No other qt4 stuff to test with.
EDIT: qstardict works, qt-recordmydesktop too.

[palinek]

I'd would like to sort this out, but both megasync & keepasx are working here...

[stefonarch]

I'm still somewhat confused about the differences between tray icons and status-notifier icons, is this issue about both? Because keepassx, recordmydesktop and qstardict do not notify anything and are in the systray.

[luis-pereira]

I'm in the same situation as @palinek. keeppassx, megasync, appset-qt and skype work Ok im my system.

[stefonarch]

Skype always worked, megasyncjust installed too. So the only one for me is appset-qt which is invisible.

[paulolieuthier]

Are you all using the lastest version of Qt, as in Arch? It's very weird that I'm the only one seeing it. It works for me only when I disable our custom icon loader engine in lxqt-qtplugin.

[luis-pereira]

@paulolieuthier I'm running Arch qt5-base 5.6.1-2

[pmattern]

@luis-pereira
Some strange findings with QupZilla's UI here are suggesting this could be related to Qt 5.7.

[stefonarch]

I'm running latest arch + lxqt stuff. Clearly I remember that when I installed appset-qt June 2 the icon in tray was working and stopped after, probably June 7, that was still with qt5.6; looking at pacman's log this would not be related to qtplugin, at least not directly

[2016-05-01 07:54] upgraded lxqt-qtplugin-git (0.10.0.1.g2b494a5-1 -> 0.10.0.5.g4a3d790-1)
[2016-05-09 09:51] reinstalled lxqt-qtplugin-git (0.10.0.5.g4a3d790-1)
[2016-05-21 12:51] upgraded lxqt-qtplugin-git (0.10.0.5.g4a3d790-1 -> 0.10.0.7.g3ad671e-1)

[2016-06-07 19:14] reinstalled lxqt-qtplugin-git (0.10.0.7.g3ad671e-1)
[2016-06-07 18:50] upgraded liblxqt-git (0.10.0.32.gf2ea70d-1 -> 0.10.0.44.g679673b-1)
[2016-06-07 18:51] upgraded libqtxdg-git (1.3.0.33.g2a38336-1 -> 1.3.0.39.gb847928-1)
[2016-06-07 18:51] upgraded lxqt-common-git (0.10.0.25.gfd6256f-1 -> 0.10.0.30.g7cf4576-1)

[luis-pereira]

@paulolieuthier Just updated to Qt 5.7.0 on Arch. Now I'm able to reproduce it.

[luis-pereira]

Can we close this ? After lxqt/lxqt-qtplugin@411f696 everything works fine to me.

[stefonarch]

The only program which wasn't displayed here correctly was appset-qt, I notice now that it works even before upgrading lxqt-qtplugin-git (0.10.0.7.g3ad671e-1 -> 0.10.0.8.g411f696-1) which makes me think that this is not related to qtplugin.
So yes, for me everything works fine.

EDIT: nope, after upgrading qt-plugin appset-qt is not displayed and main window is only displayed after doing appset-qt-lauch.sh and appset-qt but no tray.
Object::connect: No such slot MainWindow::refreshCom()

I do a full upgrade of everything now.

[paulolieuthier]

Running lastest Arch, lxqt-panel and lxqt-qtplugin. Qt4 (sni-qt) apps are still icon-less.

[stefonarch]

After full upgrade appset-qt has still problems, but I think that it's fault.
skype, megasync, qt-recordmydesktop icons are all working.

[luis-pereira]

I'm running:

• Arch with Qt 5.7.0
• lxqt-qtplugin master branch

Not running:

• sni-qt

Resulting in:

[paulolieuthier]

Of course it works if I unninstall sni-qt, but then Qt4 apps will appear in the old system tray, which is not what we want. If I checkout lxqt/lxqt-qtplugin@4a3d790 (the commit before the commit that introduces the new icon loader engine), it works perfectly.

@luis-pereira does it work for you with sni-qt installed?

[stefonarch]

I missed something, I was never running sni-qt, as it's dependency was optional. Running it I see same problems.

[paulolieuthier]

After another update, transmission-qt, which is Qt5-based (no sni-qt), is iconless as well:

[luis-pereira]

@paulolieuthier Can you pls test with the libqtxdg backport branch ?
I get this:

Although something strange happens with the Breeze icon theme.

p.s. Long delay. Real life gets in the way.

[paulolieuthier]

Transmission is back, but the sni-qt apps are still not, unfortunately:

[tsujan]

After upgrading LXQt last week, I forgot to say that all sni-qt apps are OK here.

[luis-pereira]

Actually I didn't debug the statusnotifier thing, yet.

[tsujan]

Is it possible that this difference in results is due to the icon theme? On Debian, I don't have breeze and everything is OK. On Manjaro, when breeze is activated, I see no problem but there I have only one sni-qt app.

[paulolieuthier]

I had already tried with other icon themes, same thing.

[paulolieuthier]

@luis-pereira: on top of your branch, the following patch is a workaround to the bug:

diff --git a/plugin-statusnotifier/statusnotifierbutton.cpp b/plugin-statusnotifier/statusnotifierbutton.cpp
index 0aa68c4..adc87a6 100644
--- a/plugin-statusnotifier/statusnotifierbutton.cpp
+++ b/plugin-statusnotifier/statusnotifierbutton.cpp
@@ -136,9 +136,8 @@ void StatusNotifierButton::refetchIcon(Status status)
         QIcon nextIcon;
         if (!iconName.isEmpty())
         {
-            if (QIcon::hasThemeIcon(iconName))
-                nextIcon = QIcon::fromTheme(iconName);
-            else
+            nextIcon = QIcon::fromTheme(iconName);
+            if (nextIcon.isNull())
             {
                 QDir themeDir(mThemePath);
                 if (themeDir.exists())

The thing is that QIcon::hasThemeIcon is always returning true with our icon engine.

[luis-pereira]

@paulolieuthier Thanks for the great clue. When real life gets a little bit out of the way (begining of next week) it will be much faster.

[paulolieuthier]

Although lxqt/libqtxdg#99 fixes the issue with the statusnotifier icons, lxqt/libqtxdg#97 (the backport branch) is still needed for other icons issues, like with pcmanfm-qt:

[luis-pereira]

@paulolieuthier Sure. But this particular issue is about the Status Notifier.
I made the patch from master because they are independent from each other. Both should make it to master if we found they are reliable.

[paulolieuthier]

Yeah, sure. I'm just keeping record of it.

[tsujan]

It's my turn to report a similar problem ;)
On Debian, status notifier icons were (and are) all right. But, on a newly installed Manjaro, Pidgin and Skype don't have a tray icon, while I have sni-qt, lib32-sni-qt and all libappindicators here. Both Pidgin and Skype do have tray icon under KDE.

Edit: I was wrong about Pidgin but not about Skype. Here Skype has a tray icon when run under KDE but not under LXQt.

[paulolieuthier]

@tsujan Skype does not support the Status Notifier specification, so it should appear in the old system tray plugin. Plasma turns XEmbed icons into SNIs using a bridge.

[tsujan]

Skype does not support the Status Notifier specification

On Debian and when 32-bit sni-qt is installed, Skype's tray icon appears in LXQt's Status Notifier -- I never use the old systray.

[palinek]

... icon appears in LXQt's Status Notifier -- I never use the old systray.

Did you realy get e.g. pidgin icon into SNI? I've never succeeded ...

[tsujan]

Did you realy get e.g. pidgin icon into SNI?

Yes! That requires pidgin-indicator. Until now, only Skype doesn't have an icon and only on Manjaro; I don't know what's missing here.

Edit: As far as I see, the only difference is the Qt version.

[luis-pereira]

@tsujan What do you don't see ? Only the icon or the item is not there ?

[tsujan]

@luis-pereira
First, I may be wrong but I don't think this is about an LXQt bug because, with the same version, the Skype tray icon is OK on Debian. It may be related to Qt or ... That was the reason I didn't reopen this issue.

Second, it's only about Skype so far: it has no item in the status notifier at all.