Fixed call to encode #185
Merged
Fixed call to encode #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise I was getting following error: File "src/lxml/lxml.etree.pyx", line 169, in init lxml.etree (src/lxml/lxml.etree.c:229940) TypeError: encode() argument 1 must be string without null bytes, not unicode It's rare branch, that's why this bug remained in codebase for a very long time
|
Hmm, I wonder why this poses a problem for you. This code is executed for everyone right on import... Anyway, it's actually the right thing to do here, so, thanks! |
|
I did some experiments, and found out, that this one is very hard to reproduce. Here are my steps:
Actually I don't understand, why it happens... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise I was getting following error during import:
Also vim auto-fixed trailing spaces.