-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the PyPy special cases (for PyPy 4.1) #187
Conversation
Thanks for working on this. |
Removed the PyPy special cases (for PyPy 4.1)
+1 |
@scoder Could you publish an lxml version with this change on PyPI? Thanks! |
it would be great as PyPy has now released a new version: 5.0. It has the required functionality to be compatible with the next release of lxml out of the box. |
What's the state for this change? I'm still getting errors building lxml with Pypy 5.0 |
Works for me on "master" revision 0334372, in a fresh virtualenv in which I first did |
I'm trying to install pyquery which depends on lxml with pypy 5.0 on the latest OSX. I installed pypy via Macports, if it matters:
I create an empty virtualenv:
And then try to install PyQuery and it fails with the same error I had before:
|
You need lxml trunk. Your command installs lxml-3.5.0. |
https://pypi.python.org/pypi/lxml/3.6.0 includes this. Thanks @scoder ! |
Awesome! On Thu, Mar 17, 2016 at 9:52 AM, Simon Sapin notifications@github.com
|
lxml issues found, you may want to wait until PyPy 5.0.1 (very soon). |
is it fixed now in lxml and Pypy last released versions ? |
My comment fixed an lxml issue in PyPy 5.0.1, released last year. PyPy is now at version 5.6. Please an another issue (either here or in PyPy's https://bitbucket.org/pypy/pypy/issues/ ) if there are still problems. |
PyPy trunk (and future PyPy 4.1) contains now https://bitbucket.org/pypy/pypy/commits/3144c72295ae which improves the cpyext compatibility. It removes the need for these few hacks (which never fully worked, as discussed on pypy-dev).