allow None as an attribute value, for HTML boolean attributes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -564,11 +564,14 @@ cdef int _setAttributeValue(_Element element, key, value) except -1: | |||
| if not element._doc._parser._for_html: | |||
| _attributeValidOrRaise(tag) | |||
| c_tag = _xcstr(tag) | |||
| if isinstance(value, QName): | |||
| value = _resolveQNameText(element, value) | |||
| if value is None: | |||
There was a problem hiding this comment.
Shouldn't it reject None for XML trees and only allow it for HTML trees? The latter is the only use case I can see. XML always requires at least an empty string as value.
There was a problem hiding this comment.
XML serialization produces the empty string as value, even if it is None. Is there a way to tell which tree you are in?
|
Looks like a nice feature. A comment in the (lxml.html?) docs would be perfect. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a script to convert some tags in Angular templates to a new API, and noticed that curiously lxml could parse and re-serialize boolean tags that have no value, but could not create new ones. It turns out libxml2 supports this by accepting NULL as the value for xmlSetNsProp(), creating an attribute node with NULL children instead of a text node.
This change allows None as a value for Element.set() so that those who value attributes with no value can create the same.
Note that lxml.etree.tostring() serializes these as
<form novalidate=''></form>while lxml.html.tostring() produces the value in the test.