expose collect_ids for HTMLParser as well #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoder
reviewed
Dec 6, 2016
| @@ -1615,6 +1615,8 @@ cdef class HTMLParser(_FeedParser): | |||
| - strip_cdata - replace CDATA sections by normal text content (default: True) | |||
| - compact - save memory for short text content (default: True) | |||
| - default_doctype - add a default doctype even if it is not found in the HTML (default: True) | |||
| - collect_ids - Set this to False to avoid ever-growing id cache in | |||
| long-running processes (at a bit of a performance cost) | |||
There was a problem hiding this comment.
That reads a bit biased. The downside is that you'd loose fast ID lookups, that should be mentioned instead.
|
did some rewording. you can chage it to your heart's content after your merge it as well, this is a fairly simple patch. |
|
Hmm, did you actually test if this has an impact? The code says that it shouldn't. |
|
Well I'm trying to troubleshoot a memory leak myself and having close_ids=false in my daemon with this patch doesn't seem to have an impact. |
|
More specifically, the leak is still there and having this flag doesn't seem to have slowed down the rate of the leak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's said to lower the memory footprint of the parser at the expense of increased CPU load. Some use cases might care more about the amount memory consumed than CPU time, so it might make sense to expose this parameter.