Make XMLSyntaxError have normal SyntaxError metadata #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoder
reviewed
Dec 6, 2016
| self.assertEqual(e.lineno, 1) | ||
| self.assertEqual(e.offset, 10) | ||
| except Exception as e: | ||
| self.fail('{}, not {}'.format(fail_msg, type(e))) |
There was a problem hiding this comment.
Empty format keys aren't supported in Py2.6.
|
Cool, really nice feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools (e.g. IPython) show a special error message like the following if common
SyntaxErrormetadata is available:$ PYTHONPATH=src ipython In [1]: from lxml import etree In [2]: etree.parse('src/lxml/tests/test_broken.xml') File "src/lxml/tests/test_broken.xml", line 1 <a><b></c></b></a> ^ XMLSyntaxError: Opening and ending tag mismatch: b line 1 and c, line 1, column 11This PR adds the necessary fields
filename,linenoandoffset, while makingpositiona property in order to keep it in sync withlinenoandoffsetif those are changed.