Soup hyphen in comment #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that beautifulsoup won't handle using list as `features` properly.
|
Thanks. Could you come up with a test that shows why the "--" special handling is necessary? At first glance, it seems wrong to me to add a character escape in text content (which is not serialised XML). |
|
Something like <html>
<body>
<div> Test </div>
<!-- This is -- a comment with double hyphen -->
</body>
</html>When parsing with soupparser, exception raised The lxml code that raise the exception is in |
|
hmm... It seems lxml.html can parse comment with 2 hyphens with no problem. from lxml.html import soupparser
from lxml import html
content = "<html><!-- something with -- 2 hyphen --></html>"
tree = html.fromstring(content)
print(html.tostring(tree))
tree = soupparser.fromstring(content)
print(html.tostring(tree)) |
|
I think the soup parser is simply using the wrong way to instantiate an HTML comment: |
|
aha, thanks for the advice. Pull updated |
|
Could you please also add tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues with soupparser