Fix test_elementtree with Expat 2.6.0 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feeding the parser by too small chunks defers parsing to prevent CVE-2023-52425. Future versions of Expat may be more reactive. Heavily inspired by python/cpython@4a08e7b We cannot use a @fails_with_expat_2_6_0 decorator because the test passes in ETreePullTestCase. Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
|
Thanks |
|
Is it possible to release new version because this PR has been merged? 🤔 |
scoder
pushed a commit
that referenced
this pull request
Mar 28, 2024
Feeding the parser by too small chunks defers parsing to prevent CVE-2023-52425. Future versions of Expat may be more reactive. Heavily inspired by python/cpython@4a08e7b We cannot use a @fails_with_expat_2_6_0 decorator because the test passes in ETreePullTestCase. See python/cpython#115133 See GHSA-gh68-jm46-84rf Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feeding the parser by too small chunks defers parsing to prevent CVE-2023-52425. Future versions of Expat may be more reactive.
Heavily inspired by python/cpython@4a08e7b
We cannot use a @fails_with_expat_2_6_0 decorator
because the test passes in ETreePullTestCase.
Co-authored-by: @serhiy-storchaka