Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory layout #8

Closed
bmatsuo opened this issue Nov 1, 2011 · 1 comment
Closed

Directory layout #8

bmatsuo opened this issue Nov 1, 2011 · 1 comment

Comments

@bmatsuo
Copy link

bmatsuo commented Nov 1, 2011

I just start using pgsql and I like it. Good functionality and it seems to be pretty well documented. So thank you for that =)

But I don't like the directory layout introduced in commit (6cf4313). It's really cumbersome when installed with goinstall, and in general it's a little more than necessary.

If installed with goinstall, the import path in Go source files is really complicated and hard to remember.

import "github.com/lxn/go-pgsql/src/pkg/pgsql"

(It doesn't really make since to have a directory /src/ in the import path either, because you're importing a binary file.)

The source files (in /src/pkg/pgsql) should be moved to /pgsql. It is the Go convention. So it gives a shorter, easy to remember import path.

import "github.com/lxn/go-pgsql/pgsql"

I think the examples were good in the /examples directory. The project wouldn't be cluttered, imho.

Please consider this. I think its really annoying the way it is. But otherwise, thanks again for this package! And please keep up the great work!

@lxn
Copy link
Owner

lxn commented Feb 20, 2012

The path is now even shorter, thanks :)

@lxn lxn closed this as completed Feb 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants