Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy <head> elements #478

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Tidy <head> elements #478

merged 1 commit into from
Apr 6, 2024

Conversation

edent
Copy link
Contributor

@edent edent commented Oct 1, 2023

Description

The character encoding must appear in the first 1,024 bytes - https://html.spec.whatwg.org/multipage/semantics.html#charset

The <meta> and <link> elements are self closing. No need for a trailing /

Issue Number:

#477


Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

  • List users with @ to send Notifications

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit b774f6b
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/6519c2d02d2450000982ba11
😎 Deploy Preview https://deploy-preview-478--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90
Accessibility: 88
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edent Thanks for the PR. It is highly appreciated!

@lxndrblz lxndrblz linked an issue Apr 6, 2024 that may be closed by this pull request
@lxndrblz lxndrblz added the enhancement New feature or request label Apr 6, 2024
@lxndrblz lxndrblz self-assigned this Apr 6, 2024
@lxndrblz lxndrblz merged commit 5299af6 into lxndrblz:master Apr 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character Encoding set after title.
2 participants