Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seller id support #7

Merged
merged 4 commits into from Feb 9, 2015
Merged

Seller id support #7

merged 4 commits into from Feb 9, 2015

Conversation

Hexcles
Copy link
Contributor

@Hexcles Hexcles commented Feb 9, 2015

  1. Add support to use seller_id instead of seller_email (when initialization)
  2. Polish some style problems (whitespace, indent, etc.)
  3. Update README and unit tests correspondingly.

@Hexcles
Add support for seller_id in addition to seller_email
f1427b6 
It is preferred to use seller_id to avoid exposing email address.

Now Alipay() can accept both seller_id and seller_email when init,
and raise an exception if both are missing.
@Hexcles
PEP8 style polishing
6c0d37b
@Hexcles
Update README
9927e43
@Hexcles
fix testing
c836af0
lxneng added a commit that referenced this pull request Feb 9, 2015
@lxneng
Merge pull request #7 from Hexcles/seller_id_support
d6c8a26 
Seller id support
@lxneng lxneng merged commit d6c8a26 into lxneng:master Feb 9, 2015
@lxneng
Copy link
Owner

lxneng commented Feb 9, 2015

👍
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hexcles @lxneng