Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-utils should use qtxdg-mat under LXQt #264

Closed
tsujan opened this issue Sep 12, 2021 · 22 comments
Closed

xdg-utils should use qtxdg-mat under LXQt #264

tsujan opened this issue Sep 12, 2021 · 22 comments

Comments

@tsujan
Copy link
Member

tsujan commented Sep 12, 2021

This isn't a bug in LXQt but an urgent need.

Currently, xdg-open only uses open_generic under LXQt, causing troubles like lxqt/lxqt-panel#1661.

@luis-pereira made qtxdg-mat. It should be used in xdg-open under LXQt.

@tsujan
Copy link
Member Author

tsujan commented Sep 12, 2021

Also, you may want to take a look at lxqt/lxqt-panel#1661 (comment)

@luis-pereira
Copy link
Member

Already wrote a complete patch to xdg-utils. Will publish it here next week. Wait for comments and reviews and after that submit it to upstream xdg-utils.

@luis-pereira
Copy link
Member

@tsujan Real life get's in the way. But it's ready for testing, now.
Pls try the enhance-lxqt-support branch at my fork from upstream xdg-utils.

After positive feedback I will make a merge request.

@tsujan
Copy link
Member Author

tsujan commented Dec 3, 2021

@luis-pereira
Many thanks!

I applied your patch (https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff) to xdg-utils 1.1.3+19+g9816ebb. Everything seems OK; lxqt/lxqt-panel#1661 isn't reproducible anymore.

I'll use it for a few days and report back.

@tsujan
Copy link
Member Author

tsujan commented Dec 3, 2021

@stefonarch, could you also confirm that https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff fixes lxqt/lxqt-panel#1661 without ~/.local/share/applications/defaults.list?

@stefonarch
Copy link
Member

Ok, looks like this filelight error doesn't show up anymore now. Will test for some days.

@tsujan
Copy link
Member Author

tsujan commented Dec 6, 2021

@luis-pereira
I haven't encountered any problem with your patch after three days.

@luis-pereira
Copy link
Member

I haven't encountered any problem with your patch after three days.

Nice.

@luis-pereira
Copy link
Member

@stefonarch Do you have any feedback on this ?

@tsujan
Copy link
Member Author

tsujan commented Dec 21, 2021

In case you also want to know what I see here after 17 days, it's the same as before: have encountered no problem.

@stefonarch
Copy link
Member

Sorry thought I'd said it somewhere: no issues encountered all those days.

@stefonarch
Copy link
Member

After positive feedback I will make a merge request.

News about that?

@tsujan
Copy link
Member Author

tsujan commented May 28, 2022

News about that?

@luis-pereira made the merge request 5 months ago: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48. But apparently there's a problem ("Merge blocked: the source branch must be rebased onto the target branch.")

@luis-pereira
Copy link
Member

@tsujan @stefonarch I will rebase after the weekend. There weren't any merge conflicts when I made the merge request.

@tsujan
Copy link
Member Author

tsujan commented May 28, 2022

There weren't any merge conflicts when I made the merge request.

I know; saw it only today.

@luis-pereira
Copy link
Member

Rebased.

@yan12125
Copy link
Member

yan12125 commented Jun 1, 2022

Upstream xdg-utils seems no so active. I'm afraid the patch will not be merged soon. I uploaded https://aur.archlinux.org/packages/xdg-utils-lxqt, so users on Arch-like systems can use the patched version easily.

@tsujan
Copy link
Member Author

tsujan commented Jun 1, 2022

Upstream xdg-utils seems no so active.

Can't we explicitly request a review there?

@yan12125
Copy link
Member

yan12125 commented Jun 1, 2022

I didn't find a button for requesting a reviewer on GitLab. I just pinged the one who merged recent merge requests and hopefully that will work. Both https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/29 and https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/42 were merged by https://gitlab.freedesktop.org/faure, on Dec 2020 and Feb 2022, respectively.

@tsujan
Copy link
Member Author

tsujan commented Sep 8, 2023

We're out of luck; the patch has a conflict again: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48

@luis-pereira
Copy link
Member

@tsujan
Copy link
Member Author

tsujan commented Sep 21, 2023

Very good news! Now xdg-open is reliable under LXQt, through and besides qtxdg-mat :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants