New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg-utils
should use qtxdg-mat
under LXQt
#264
Comments
Also, you may want to take a look at lxqt/lxqt-panel#1661 (comment) |
Already wrote a complete patch to |
@tsujan Real life get's in the way. But it's ready for testing, now. After positive feedback I will make a merge request. |
@luis-pereira I applied your patch (https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff) to I'll use it for a few days and report back. |
@stefonarch, could you also confirm that https://gitlab.freedesktop.org/luis-pereira/xdg-utils/-/commit/d2adf5efdc259a63028f8d4f21569c1557b8cfff fixes lxqt/lxqt-panel#1661 without |
Ok, looks like this filelight error doesn't show up anymore now. Will test for some days. |
@luis-pereira |
Nice. |
@stefonarch Do you have any feedback on this ? |
In case you also want to know what I see here after 17 days, it's the same as before: have encountered no problem. |
Sorry thought I'd said it somewhere: no issues encountered all those days. |
News about that? |
@luis-pereira made the merge request 5 months ago: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48. But apparently there's a problem ("Merge blocked: the source branch must be rebased onto the target branch.") |
@tsujan @stefonarch I will rebase after the weekend. There weren't any merge conflicts when I made the merge request. |
I know; saw it only today. |
Rebased. |
Upstream xdg-utils seems no so active. I'm afraid the patch will not be merged soon. I uploaded https://aur.archlinux.org/packages/xdg-utils-lxqt, so users on Arch-like systems can use the patched version easily. |
Can't we explicitly request a review there? |
I didn't find a button for requesting a reviewer on GitLab. I just pinged the one who merged recent merge requests and hopefully that will work. Both https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/29 and https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/42 were merged by https://gitlab.freedesktop.org/faure, on Dec 2020 and Feb 2022, respectively. |
We're out of luck; the patch has a conflict again: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/48 |
Very good news! Now |
This isn't a bug in LXQt but an urgent need.
Currently,
xdg-open
only usesopen_generic
under LXQt, causing troubles like lxqt/lxqt-panel#1661.@luis-pereira made
qtxdg-mat
. It should be used inxdg-open
under LXQt.The text was updated successfully, but these errors were encountered: