Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better layout for config dialog #290

Merged
merged 1 commit into from
Dec 14, 2021
Merged

A better layout for config dialog #290

merged 1 commit into from
Dec 14, 2021

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Dec 14, 2021

As suggested by @stefonarch.

Closes #289

@stefonarch
Copy link
Member

stefonarch commented Dec 14, 2021

Quite the same as my branch ;)
I thought all the files should be renamed too, advancedsettings.* → generalsettings.* and basicsettings.* → position.* - it could be confusing later keeping the old names.

@tsujan
Copy link
Member Author

tsujan commented Dec 14, 2021

I thought all the files should be renamed too,

The less code change, the safer. What's important is what the user sees.

@stefonarch
Copy link
Member

Not even some comment for the coders in 2050 ;) ?

Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@tsujan
Copy link
Member Author

tsujan commented Dec 14, 2021

Not even some comment for the coders in 2050 ;) ?

Maybe later, in a separate PR, but I don't mean 2049.

@tsujan tsujan merged commit 99e0ae8 into master Dec 14, 2021
@tsujan tsujan deleted the better_layout branch December 14, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle "Do not disturb" from tray
2 participants