Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Misplaced volume symbol and wrong name #57

Closed
libalis opened this issue Feb 16, 2022 · 7 comments · Fixed by #68
Closed

[Bug] Misplaced volume symbol and wrong name #57

libalis opened this issue Feb 16, 2022 · 7 comments · Fixed by #68

Comments

@libalis
Copy link

libalis commented Feb 16, 2022

KDE-Plasma
KDE-Plasma (1)

As you can see on the screenshots, KDE Plasma is the only theme where the volume icon is shifted downwards. I also thought KDE Plasma had the letters k, d, e and p in capital letters, but this is apparently not the case here.

System Information
  • Distribution & Version: openSUSE Tumbleweed
  • Kernel: 5.16.8
  • Qt Version: 5.15
  • lxqt-build-tools Version: 1.0.0
  • libqtxdg Version: 1.0.0
  • Package version: 1.0.0
@stefonarch
Copy link
Member

The problem is more that some other icons don't reserve the transparent 3px on top for the blue upper line which appears usually on hovering.
And brightness is not styled at all in the theme and with a dark palette it looks out of place. We agreed that usually nobody will use a dark palette in this theme, but at least the button should be in line.

Maybe we should remove the hover effect.

vokoscreenNG-2022-02-17_08-46-25.mp4

@stefonarch
Copy link
Member

stefonarch commented Feb 17, 2022

If you like to test: copy the kde-plasma theme folder from /usr/share/lxqt/themes/ to ~/.local/share/lxqt/themes/ and change the first part of the volume plugin in lxqt-panel.qss like that:

/*
 * Volume plugin
 */
#VolumePlugin QToolButton {
    margin: 3px;
    border-top: 3px solid transparent;
    color: rgba(54, 54, 54, 60%);
}


VolumePopup {
    border: 1px solid rgba(155, 155, 155, 100%);
    background:rgba(240, 240, 240, 100%);
    padding: 4px;
}

You'll find the modified theme on top on the themes list in lxqt-appearance.

@libalis
Copy link
Author

libalis commented Feb 17, 2022

I understand, thank you, maybe for consistency reasons this margin should be deleted completely.
But what about the second point: the name (Kde-plasma instead of KDE Plasma)?

@stefonarch
Copy link
Member

Prepared a PR for both things, but others should be merged before probably.

@libalis
Copy link
Author

libalis commented Apr 6, 2022

Great news. Thank you so much.

@ghost
Copy link

ghost commented Apr 7, 2022

looked at the .qss file and it appears they are intended to appear in Mount Plugin and others

Changing #LXQtMountPlugin MountButton to #LXQtMountPlugin restores the overline.

#LXQtMountPlugin MountButton{

This makes me think overlines were intended here, but there is no effect in World Clock and others.

@stefonarch
Copy link
Member

I've no problem with that, will look into it, this should apply also on backlight plugin I guess.
On my vertical panel I saw that for the keyboard indicator it doesn't suit well, the underlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants