Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System statistics network widget doesn't remember Maximum #1249

Open
troffasky opened this issue Jan 28, 2017 · 6 comments · Fixed by lxqt/lxqt-panel#395
Open

System statistics network widget doesn't remember Maximum #1249

troffasky opened this issue Jan 28, 2017 · 6 comments · Fixed by lxqt/lxqt-panel#395
Projects

Comments

@troffasky
Copy link

Expected Behavior

Changes to "Maximum" slider should be saved on Close

Current Behavior

Changes to "Maximum" slider are forgotten when Close is clicked

Steps to Reproduce (for bugs)
  1. Add system statistics widget to panel
  2. Set Type to Network
  3. Adjust Maximum slider
  4. Click Close
System Information
@pmattern
Copy link
Contributor

Confirmed as depicted above running yesterday's master checkouts of all LXQt components including lxqt/lxqt-panel@94a534b1 on Arch Linux.
At first glance other settings of the plugin do not seem to suffer from the problem.

@troffasky
It would be nice if you could have another close look at the various other settings of the plugin to see whether really this one setting only is affected.

@troffasky
Copy link
Author

"Logarithmic scale" checkbox is remembered, associated steps are not. All other settings seem to be remembered.

@tsujan
Copy link
Member

tsujan commented Feb 25, 2017

I confirm this too. I'm sure that the setting was saved before but I don't know when this regression started because I saved the setting about 2 years ago ;)

@palinek
Copy link
Contributor

palinek commented Feb 28, 2017

Please, have a look on lxqt/lxqt-panel#395

@palinek palinek closed this as completed Mar 1, 2017
@pmattern
Copy link
Contributor

pmattern commented Mar 1, 2017

Running lxqt/lxqt-panel@c708e7ae only values ≥1kB/s are saved correctly. Values <1kB/s, albeit eligible by the slider, always fall back to 1B/s when reopening the dialogue.

Besides not mentioned in this issue's title it turned out the number of steps of the "Logarithmic scale" isn't saved either. Any chance you can have a look at this, too?

@pmattern pmattern reopened this Mar 1, 2017
@tsujan
Copy link
Member

tsujan commented Mar 1, 2017

Values <1kB/s, albeit eligible by the slider, always fall back to 1B/s when reopening the dialogue.

I think the minimum value of the maximum should be changed to a reasonable number, 10kKB/s, for example, or even more.

EDIT: 128kB seems more sensible to me.

the number of steps of the "Logarithmic scale" isn't saved either.

I haven't tested it but if so, it should be about a missing line of code too.

@agaida agaida added this to Needs triage in Issues Jul 14, 2018
@agaida agaida moved this from Needs triage to Low priority in Issues Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issues
  
Low priority
Development

Successfully merging a pull request may close this issue.

4 participants