Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If default file name is empty "save to folder setting" is not respected #233

Open
ralf3u opened this issue Dec 9, 2020 · 12 comments
Open

Comments

@ralf3u
Copy link

ralf3u commented Dec 9, 2020

if in the options the default file name is changed to empty, so without name, then there are 2 mistakes in the save-window:

  • wrong directory
  • there is the user name in the File name
Expected Behavior

save-window should respect the settings of the options

Current Behavior

save-window does not respect the settings of the options

Possible Solution

I think 3 things need to be done in the save-window:

  1. no file type in the File name (there is already a special field for that called "File type")
  2. File Name should be exactly like in the options
  3. same directory like in the options
Steps to Reproduce (for bugs)
  1. open ScreenGrab
  2. open the options
  3. click on "Main"
  4. delete the name "screen"
  5. click on "Save"
  6. press ctrl+s: (2 mistakes: wrong directory and user name in the File Name)
Context

save-window should always follow the settings of the options

System Information
  • Distribution & Version: Lubuntu 20.10
  • LXQt: 0.15.0
  • Qt Version: 5.14.2
  • ScreenGrab: 2.0.1
  • Qt: 5.14.2
@stefonarch
Copy link
Member

stefonarch commented Dec 9, 2020

True. If no default file name is given it will ignore directory and save to ~/tmp.<extension>
But it's a very rare condition.

Solution could be that default filenname isn't allow to be empty.

@tsujan
Copy link
Member

tsujan commented Dec 9, 2020

Frankly, I didn't understand a word of this report. What's "symbol-bar"? What's "General: delete screen"?!! Why do you use the word "symbol" so many times?

@stefonarch
Copy link
Member

"screen" is the default file name in the settings.
I suspect there's a lot of google translate stuff.

@ralf3u
Copy link
Author

ralf3u commented Dec 9, 2020

@stefonarch
"Solution could be that default filenname isn't allow to be empty."

If this is the case, then at least it would be good to realize those 2 points in the save-window:

  1. no file type in the File name (there is already a special field for that called "File type")
  2. the file name should be marked, like for example in LibreOffice, so it can be erased faster

@stefonarch stefonarch changed the title save-window does not respect the settings of the options If default file name is empty "save to folder setting" is not respected Dec 9, 2020
@ralf3u
Copy link
Author

ralf3u commented Dec 9, 2020

@stefonarch
"Solution could be that default filenname isn't allow to be empty."

somehow this is not true, because if in the options I activate the checkbox to have the date and time in the name (so the name is not really empty), then there are still 2 mistakes in the save-window:

  • wrong directory
  • user name in the File name

@tsujan
Copy link
Member

tsujan commented Dec 9, 2020

@tsujan, These are the answers to your question:

@ralf3u, if you want your comments to be read, don' make up terms; learn to use the real terms instead, like toolbar and icon (if I've correctly guessed what yo mean). We don't have time to decipher your comments.

Here, we use English to communicate with each other, not to confuse each other.

@ralf3u
Copy link
Author

ralf3u commented Dec 9, 2020

@tsujan
I wrote again the issue because I did too many mistakes; I'm sorry for that

@tsujan
Copy link
Member

tsujan commented Dec 9, 2020

@ralf3u

Now it's much better. Thanks.

Try to make your future comments as short as possible, so that the reader could understand them quickly.

@stefonarch
Copy link
Member

stefonarch commented Dec 9, 2020

  • user name in the File name

?

I see this behaviour:

  1. leave empty both default save directory and default file: Name > saving to ~ as ..png or ..jpg
  2. Set /tmp in default save directory and leave empty Name > saving to ~/tmp.png

This is the issue/bug.

  1. set both and all is perfect.

@ralf3u
Copy link
Author

ralf3u commented Dec 12, 2020

and there is another issue: a hyphen before the date:
go in the options, click on "Advanced", and then activate "Insert current date and time", then click in the options on "Save"

now press ctrl+s: in the File name there is a hyphen before the date

it should be without hyphen before the date, because in the options there was no hyphen before the date;
I mean, if I really wanted to have always a hyphen before the date, then I can enter it in options in "Advanced" in the Template

Should I open a new issue for that?

@stefonarch
Copy link
Member

Should I open a new issue for that?

Please not.

This happens when filename is left empty, and could be solved by make this mandatory.
screen-12-10-20.png is the way all works fine.

@ralf3u
Copy link
Author

ralf3u commented Dec 12, 2020

this is a pity, because the names of my screenshots start with the date;
if one day you decide to delete the hyphen, or rather if you find a way to delete the hyphen, then please delete also the file type in the file name, because then it is easier to add some words at the end of the file name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants