Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error 导出？ #4

Closed
fzdwx opened this issue Mar 2, 2023 · 12 comments
Closed

error 导出？ #4

fzdwx opened this issue Mar 2, 2023 · 12 comments

Comments

@fzdwx
Copy link
Contributor

fzdwx commented Mar 2, 2023

不放在 internal 下
image
@lxzan
Copy link
Owner

lxzan commented Mar 2, 2023

可以考虑下

@lxzan
Copy link
Owner

lxzan commented Mar 3, 2023

一般不会用err来做比较判断, 不导出的话显得干净点. 你有什么特殊理由吗?

@fzdwx
Copy link
Contributor Author

fzdwx commented Mar 3, 2023

比如说 写 的时候，返回的 error，判断是否是关闭的

@lxzan
Copy link
Owner

lxzan commented Mar 3, 2023

比如说 写 的时候，返回的 error，判断是否是关闭的

gws出现错误就会关闭连接, 协议错误, IO错误, 压缩错误, 容量溢出...

@lxzan
Copy link
Owner

lxzan commented Mar 3, 2023

今天发了个大版本, 以后尽量少折腾吧 :)

@lxzan
Copy link
Owner

lxzan commented Mar 3, 2023

下次大更该提供客户端了

@fzdwx
Copy link
Contributor Author

fzdwx commented Mar 3, 2023

可以

@lxzan
Copy link
Owner

lxzan commented Mar 5, 2023

客户端写好了, 有空可以帮忙看下

@fzdwx
Copy link
Contributor Author

fzdwx commented Mar 5, 2023

好的，已经拉了。

但是一般后端用 client 的场景可能比较少

@lxzan
Copy link
Owner

lxzan commented Mar 5, 2023

顺便提供了

@lxzan
Copy link
Owner

lxzan commented Mar 6, 2023

想发客户端了

@fzdwx
Copy link
Contributor Author

fzdwx commented Mar 6, 2023

发呀，不过我暂时还用不到

@lxzan lxzan closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lxzan @fzdwx