Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture Replacement: PS button prompts? #16

Closed
GamerzHell9137 opened this issue Aug 16, 2022 · 12 comments
Closed

Texture Replacement: PS button prompts? #16

GamerzHell9137 opened this issue Aug 16, 2022 · 12 comments

Comments

@GamerzHell9137
Copy link

I know this is not an issue or a feature of the mod but is there a possibility to implement texture replacement so we can add PS button prompts? Weird that RF5 doesn't have them but RF4S did.

@Lyall
Copy link
Owner

Lyall commented Aug 16, 2022

So I've been look at this right now along with the Steam Deck controller bug and I've dumped the texture atlas for the controller icons and it does indeed have PlayStation button prompts. As for getting those enabled/used, that's something to keep looking in to.

sactx-1024x1024-DXT5-PadIconSpriteAtlas-52801ff0

@BenjaminBrandtner
Copy link

I don't know if this is helpful: To my surprise my game was using Playstation button prompts from the beginning.

I'm using a "Thrustmaster ESWAP PRO for PS4 and PC" Controller and when I open the "Controller Configuration" from within the Steam Overlay it shows a picture of a PS4 controller.
So if Steam thinks that you're using a PS4 controller it seems the game will automatically use PS button prompts.

@Lyall
Copy link
Owner

Lyall commented Aug 17, 2022

I don't know if this is helpful: To my surprise my game was using Playstation button prompts from the beginning.

I'm using a "Thrustmaster ESWAP PRO for PS4 and PC" Controller and when I open the "Controller Configuration" from within the Steam Overlay it shows a picture of a PS4 controller. So if Steam thinks that you're using a PS4 controller it seems the game will automatically use PS button prompts.

That's interesting, I tried spoofing the controller ID but it wasn't loading the appropriate button set. If you've actually seen PS4 prompts in game then I'll need to keep looking at this.

Can you confirm if the controller icons matched any of those in the texture atlas I posted previously? Steam Input has the ability to load controller glyphs itself which may be what's happening and in that case it won't be pulled from game assets.

@Lyall
Copy link
Owner

Lyall commented Aug 17, 2022

Okay, I was able to change the controller type and yeah DS4 icons show up now. What's odd is that this should be happening correctly without the need of a mod. I wonder if Rune Factory 5 just has a messed up implementation of Steam Input. That might account for why the Steam Deck uses keyboard glyphs instead of generic gamepad ones.

image

Edit: Here's the Switch controller type too. These do use game assets so they're not being injected by Steam Input.

image

@kokoropaint
Copy link

My DS4 has been recognized fine by RF5, I haven't had any issues since starting the game. I wonder why it's not working for some people.

@Lyall
Copy link
Owner

Lyall commented Aug 18, 2022

My DS4 has been recognized fine by RF5, I haven't had any issues since starting the game. I wonder why it's not working for some people.

Yeah it's odd, as far as I can tell looking at the pseudocode I can access, it should be working fine. Regardless, I've added the option for controller icon overriding in the latest release (v0.1.4 as of this). Hopefully this will be of some use to those who aren't getting the correct controller icons.

@GamerzHell9137
Copy link
Author

GamerzHell9137 commented Aug 18, 2022

I think there are 2 reasons why people can't access it and those are:

  1. Using 3rd party controller apps that emulate other controllers (I'm actually using DS4Windows with my DS4 controller because it makes it possible to use higher pooling rates which means lower latency)
  2. Using controllers that are not Sony licensed or an Xbox controller and want PS prompts

After i disabled DS4 Windows it let me show PS buttons but there might be other reasons as to why it could not work for others so i think having an option to force one over the other whatever controller you have is a great addition to the mod, thanks for the implementation!

@GamerzHell9137
Copy link
Author

I've got a slight nitpick tho. From the image above seems like numbered controls are there too in the game files. Any way to enable them too? Its for those random knockoff Chinese controllers. Hardly think anyone will use but if there's a way to enable them i wouldn't be opposed for the option for those individuals who want to use the numbers for some reason lol

@GamerzHell9137
Copy link
Author

Also PC prompts are disabled when you force one of them so an option for PC propts only would be nice too.

@Lyall
Copy link
Owner

Lyall commented Aug 20, 2022

I've got a slight nitpick tho. From the image above seems like numbered controls are there too in the game files. Any way to enable them too? Its for those random knockoff Chinese controllers. Hardly think anyone will use but if there's a way to enable them i wouldn't be opposed for the option for those individuals who want to use the numbers for some reason lol

I've tried every controller "type" the game offers and none of them seem to use the generic gamepad glyphs. It's likely that they're just leftovers and unused.

Also PC prompts are disabled when you force one of them so an option for PC propts only would be nice too.

Keyboard glyphs are loaded in a different way using a different texture atlas so if you want working keyboard glyphs then you just need to disable the controller icon override.

@GamerzHell9137
Copy link
Author

I've got a slight nitpick tho. From the image above seems like numbered controls are there too in the game files. Any way to enable them too? Its for those random knockoff Chinese controllers. Hardly think anyone will use but if there's a way to enable them i wouldn't be opposed for the option for those individuals who want to use the numbers for some reason lol

I've tried every controller "type" the game offers and none of them seem to use the generic gamepad glyphs. It's likely that they're just leftovers and unused.

Also PC prompts are disabled when you force one of them so an option for PC propts only would be nice too.

Keyboard glyphs are loaded in a different way using a different texture atlas so if you want working keyboard glyphs then you just need to disable the controller icon override.

Isn't RF5SteamInput.SteamInputManager.ControllerType.Default the default aka PC prompts? Can't that be set as PC in the values for controller type in the config file?

@Algester
Copy link

Algester commented Aug 23, 2022

I don't know if this is helpful: To my surprise my game was using Playstation button prompts from the beginning.

I'm using a "Thrustmaster ESWAP PRO for PS4 and PC" Controller and when I open the "Controller Configuration" from within the Steam Overlay it shows a picture of a PS4 controller. So if Steam thinks that you're using a PS4 controller it seems the game will automatically use PS button prompts.

this is game by game basis mind you (K-T games are infamous of this) not all games are parsing through steamapi UNREAL engine based games are smart enough to switch controller prompts if the game detects it not much for unity yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants