Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support using nightly version #203

Closed
kemingy opened this issue Aug 13, 2023 · 6 comments · Fixed by #204
Closed

feat: support using nightly version #203

kemingy opened this issue Aug 13, 2023 · 6 comments · Fixed by #204

Comments

@kemingy
Copy link
Contributor

kemingy commented Aug 13, 2023

As we accomplished in lycheeverse/lychee#1212. We're now able to use the nightly release. However, I found that this action will add a v prefix to the lycheeVersion.

I'm not sure which way you prefer:

  • remove the v prefix and set the default lycheeVersion to v0.13.0
    • this might break some users if they're using a specific version
  • add a new argument

What do you think? I'm glad to create a PR.

@mre
Copy link
Member

mre commented Aug 13, 2023

I would say the first option is the cleanest, as this is clearly a paper cut, which can trip people up.

In order to avoid breaking changes, let's prepare a PR which removes the v prefix and release a version 2 of the action along with #86 and #85. Sounds good?

@kemingy
Copy link
Contributor Author

kemingy commented Aug 13, 2023

SGTM. Let me create PR for this.

@tooomm
Copy link
Contributor

tooomm commented Oct 29, 2023

As it fits the idea...
Did you also consider to allow lycheeVersion: latest to grab not the nightly, but the latest full release.

Currently, this repo needs a manual push to match a new release on the main repo, e.g. 5d778f1.

@mre
Copy link
Member

mre commented Nov 30, 2023

@kemingy, do you have any thoughts on this? I'm not sure what to do here. I wouldn't be against adding such an option, but it might be some additional work.

@kemingy
Copy link
Contributor Author

kemingy commented Dec 1, 2023

I think it requires additional logic to get the latest release version in the action.

One possible cmd is:

gh release list --repo lycheeverse/lychee --exclude-drafts --exclude-pre-releases --limit 1 | awk '{print $4}'

@mre
Copy link
Member

mre commented Dec 1, 2023

Thanks for the info. I wouldn't mind adding support for it if someone is willing to create a pull request for it. If it's a lot of work, then it's out of scope for now.

@mre mre closed this as completed in #204 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants