Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move url relationships to details tab #355

Merged
merged 15 commits into from
Aug 13, 2023
Merged

Conversation

lydavid
Copy link
Owner

@lydavid lydavid commented Aug 5, 2023

resolves #348

@lydavid lydavid changed the title Dl/move urls to details feat: move urls to details Aug 5, 2023
@lydavid lydavid changed the title feat: move urls to details feat: move url relationships to details tab Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 64.41% and project coverage change: -0.33% ⚠️

Comparison is base (6b45f96) 71.94% compared to head (04b00dd) 71.62%.
Report is 7 commits behind head on beta.

❗ Current head 04b00dd differs from pull request most recent head 8fa65d5. Consider uploading reports for the commit 8fa65d5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #355      +/-   ##
============================================
- Coverage     71.94%   71.62%   -0.33%     
  Complexity      393      393              
============================================
  Files           141      141              
  Lines          5906     6079     +173     
  Branches       1008     1036      +28     
============================================
+ Hits           4249     4354     +105     
- Misses          918      965      +47     
- Partials        739      760      +21     
Files Changed Coverage Δ
...ly/david/mbjc/ui/work/details/WorkDetailsScreen.kt 28.98% <24.24%> (-4.35%) ⬇️
.../david/mbjc/ui/event/details/EventDetailsScreen.kt 23.33% <26.66%> (+4.58%) ⬆️
...c/ui/instrument/details/InstrumentDetailsScreen.kt 26.00% <36.36%> (+4.04%) ⬆️
...avid/mbjc/ui/series/details/SeriesDetailsScreen.kt 48.00% <40.00%> (-2.00%) ⬇️
...id/mbjc/ui/release/details/ReleaseDetailsScreen.kt 35.50% <53.33%> (+8.30%) ⬆️
...ly/david/mbjc/ui/area/details/AreaDetailsScreen.kt 38.29% <57.14%> (+4.01%) ⬆️
...bjc/ui/recording/details/RecordingDetailsScreen.kt 44.89% <63.15%> (+6.66%) ⬆️
.../david/mbjc/ui/label/details/LabelDetailsScreen.kt 51.16% <80.00%> (+12.45%) ⬆️
.../releasegroup/details/ReleaseGroupDetailsScreen.kt 66.66% <80.00%> (+4.76%) ⬆️
.../david/mbjc/ui/place/details/PlaceDetailsScreen.kt 58.82% <83.87%> (+8.82%) ⬆️
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

David Ly added 3 commits August 13, 2023 13:35
previously, we couldn't get it to build without bumping the version, but it seems to work now
@lydavid lydavid merged commit 9ab6091 into beta Aug 13, 2023
2 of 3 checks passed
@lydavid lydavid deleted the dl/move-urls-to-details branch August 13, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move url relationships to details tab
1 participant