Crash when navigating to a release group from an artist, then clicking back

[lydavid]

Issue did not exist before ktor changes: e219759

Temp fix

Comment out

key = lazyPagingItems.itemKey { it.id },

We only lose the ability to animate sort

Log:

FATAL EXCEPTION: main
Process: io.github.lydavid.musicsearch, PID: 8005
java.lang.IllegalArgumentException: Key "af7347df-ef5a-3c41-826d-d884f8916c17" was already used. If you are using LazyColumn/Row please make sure you provide a unique key for each item.

Problem

Somehow we're inserting a second copy of a rg, but with artist_credit_names.

• Note that this is a query, not the rg table itself, hence why duplicate rg id is possible

  • inspecting artist_credit, we see there's an entry for the empty string

• Notice that we're matching this rg with the artist_credit_names "" (not NULL) and a-ha

• why does using ktor vs retrofit cause any issue like this? it's possible it's due to some other changes in that massive PR