Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate dagger/hilt to koin for multiplatform DI #434

Merged
merged 20 commits into from
Sep 12, 2023
Merged

Conversation

lydavid
Copy link
Owner

@lydavid lydavid commented Sep 9, 2023

resolves #407

@lydavid lydavid changed the title chore: migrate dagger/hilt to koin for multiplatform DI feat: migrate dagger/hilt to koin for multiplatform DI Sep 10, 2023
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 76.11% and project coverage change: -0.41% ⚠️

Comparison is base (900e747) 73.11% compared to head (260faad) 72.71%.
Report is 1 commits behind head on beta.

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #434      +/-   ##
============================================
- Coverage     73.11%   72.71%   -0.41%     
- Complexity      272      273       +1     
============================================
  Files           104      106       +2     
  Lines          4575     4610      +35     
  Branches        756      756              
============================================
+ Hits           3345     3352       +7     
- Misses          663      692      +29     
+ Partials        567      566       -1     
Files Changed Coverage Δ
...pp/src/main/java/ly/david/mbjc/AndroidAppModule.kt 0.00% <0.00%> (ø)
.../main/java/ly/david/mbjc/MusicSearchApplication.kt 0.00% <0.00%> (ø)
...id/mbjc/services/NowPlayingNotificationListener.kt 0.00% <0.00%> (ø)
...pp/src/main/java/ly/david/mbjc/ViewModelsModule.kt 100.00% <100.00%> (ø)
...pp/src/main/java/ly/david/mbjc/di/AppDataModule.kt 100.00% <100.00%> (ø)
app/src/main/java/ly/david/mbjc/ui/MainActivity.kt 71.42% <100.00%> (+7.14%) ⬆️
...src/main/java/ly/david/mbjc/ui/TopLevelScaffold.kt 62.20% <100.00%> (+0.29%) ⬆️
...rc/main/java/ly/david/mbjc/ui/TopLevelViewModel.kt 45.60% <100.00%> (ø)
...rc/main/java/ly/david/mbjc/ui/area/AreaScaffold.kt 85.80% <100.00%> (ø)
...ava/ly/david/mbjc/ui/area/AreaScaffoldViewModel.kt 94.73% <100.00%> (ø)
... and 66 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lydavid lydavid marked this pull request as ready for review September 12, 2023 03:38
@lydavid lydavid merged commit 147bc9c into beta Sep 12, 2023
4 of 5 checks passed
@lydavid lydavid deleted the dl/koin branch September 12, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace hilt and dagger with koin for multiplatform DI
1 participant