-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate dagger/hilt to koin for multiplatform DI #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c PagedList for releases
…c PagedList for entities singleton will make these always have the same entity id as the first entity you click into
lydavid
commented
Sep 10, 2023
lydavid
commented
Sep 10, 2023
…/koin # Conflicts: # gradle/libs.versions.toml
…(libs.koin.ksp.compiler) but some tests are failing
…gate to the relations tab multiple times throughout a single test suite run
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## beta #434 +/- ##
============================================
- Coverage 73.11% 72.71% -0.41%
- Complexity 272 273 +1
============================================
Files 104 106 +2
Lines 4575 4610 +35
Branches 756 756
============================================
+ Hits 3345 3352 +7
- Misses 663 692 +29
+ Partials 567 566 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #407