Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <details> without <summary> #77

Open
the-blank-x opened this issue Jun 11, 2023 · 1 comment
Open

Support <details> without <summary> #77

the-blank-x opened this issue Jun 11, 2023 · 1 comment

Comments

@the-blank-x
Copy link

the-blank-x commented Jun 11, 2023

URL

The bottom of the comment in https://tildes.net/~games/160b/any_android_games_that_are_worth_playing_these_days#comment-85o1
https://tildes.net/~talk/145a/unpopular_opinion_wikipedias_old_look_was_much_better_than_the_new_one#comment-7ovd

Screenshot

Description

Whenever a <details> element with no <summary> is encountered, Link Hints does not add a hint to the default "Details" text of the element. I can also reproduce it here: t.html.gz

Debug info

Debug info
{
  "version": "1.3.1",
  "browser": "firefox",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:113.0) Gecko/20100101 Firefox/113.0",
  "browserInfo": {
    "name": "Firefox",
    "vendor": "LibreWolf",
    "version": "113.0.2-1",
    "buildID": "20230531125735"
  },
  "platformInfo": {
    "os": "linux",
    "arch": "x86-64"
  },
  "storage.sync": {
    "normal.ctrl-j": "EnterHintsMode_Click",
    "normal.ctrl-k": "EnterHintsMode_BackgroundTab",
    "normal.ctrl-J": "EnterHintsMode_ManyClick",
    "normal.ctrl-K": "EnterHintsMode_ManyTab",
    "normal.ctrl-L": "EnterHintsMode_Select",
    "normal.ctrl-:": "EnterHintsMode_ForegroundTab",
    "debug.Background.PREFER_WINDOWS": false,
    "debug.ElementManager.ROLES_CLICKABLE": [
      "button",
      "checkbox",
      "link",
      "menuitem",
      "menuitemcheckbox",
      "menuitemradio",
      "option",
      "radio",
      "searchbox",
      "spinbutton",
      "switch",
      "tab",
      "textbox"
    ],
    "hints.ctrl-Enter": "ActivateHintAlt",
    "debug.ElementManager.ATTRIBUTES_CLICKABLE": [
      "aria-checked",
      "aria-selected",
      "data-dismiss",
      "data-ember-action",
      "data-image-url",
      "data-line-number",
      "data-permalink-path"
    ],
    "debug.ElementManager.REGEX_CLICKABLE_CLASS": "\\bcm-|ͼ|\\bmtk|sparkline-year-label|js-wiki-toggle-collapse"
  },
  "storage.local": {
    "tutorialShown": true
  },
  "language": "en-US"
}
@lydell
Copy link
Owner

lydell commented Jun 11, 2023

TIL:

  • The HTML specification for <details> requires the <summary> element to be present, but still defines how user agents should deal with a missing summary:

    The first summary element child of the element, if any, represents the summary or legend of the details. If there is no child summary element, the user agent should provide its own legend (e.g. "Details").

  • That sites actually rely on this.

Test case:

stuff

@lydell lydell changed the title Missing hint on some tildes.net comments' <details> Support <details> withou <summary> Jun 11, 2023
@lydell lydell changed the title Support <details> withou <summary> Support <details> without <summary> Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants