Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors display below <dialog>s #98

Open
Mehgugs opened this issue May 17, 2024 · 3 comments
Open

errors display below <dialog>s #98

Mehgugs opened this issue May 17, 2024 · 3 comments

Comments

@Mehgugs
Copy link

Mehgugs commented May 17, 2024

Recently I've transitioned my modals to use native elements, but when I encounter errors via elm-watch the in-app error view is below the modal.

Elm's debugger can be popped out to a separate window which solves this problem, perhaps something similar could be done with elm-watch?

@lydell
Copy link
Owner

lydell commented May 17, 2024

Thanks for the report!

I suppose if elm-watch uses a <dialog> too, maybe it wins over your own dialogs?

@pete-murphy
Copy link

It seems like <dialog>s opened with .show() will use a stacking context that respects z-index etc., but <dialog>s opened with .showModal() will stack in order that they were opened. And a <dialog> opened with .showModal() will appear above any opened with .show() from what I can tell. https://codepen.io/ptrfrncsmrph-the-vuer/pen/gOJPPor

So if elm-watch uses .showModal(), it would probably win would be my guess 🤷

@lydell
Copy link
Owner

lydell commented May 18, 2024

Cool, thanks for making that demo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants