Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import assertions #90

Closed
lydell opened this issue Oct 2, 2021 · 2 comments
Closed

Support import assertions #90

lydell opened this issue Oct 2, 2021 · 2 comments

Comments

@lydell
Copy link
Owner

lydell commented Oct 2, 2021

https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#import-assertions

TypeScript 4.5 supports import assertions, so it’s time to add support for them in this plugin too.

@danielweck
Copy link

danielweck commented Jan 20, 2022

Hello @lydell just a quick message of appreciation for your work, and I hope you will find time to maintain your implementation and stay in sync with the latest TypeScript features (including import assertions).

I have just recently discovered eslint-plugin-simple-import-sort which I am now using alongside eslint-plugin-import with eslint-import-resolver-typescript (my project is hybrid Javascript / Typescript ... your ESLint import plugin works fine :)

Cheers!

PS: adopting your ESLint plugin allowed me to remove "import sort" Visual Studio Extensions which were causing issues in my workflow.

@lydell lydell closed this as completed in e0b3e26 Mar 26, 2022
@lydell
Copy link
Owner Author

lydell commented Mar 26, 2022

Turns out no changes were needed. Import assertions have worked all along. Those of you who 👍ed the issue, if you did so because you had trouble with import assertions – please open new issues with steps to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants