Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-pty --auto-exit: Commands can exit 0 unexpectedly in GitHub Actions #45

Open
lydell opened this issue Sep 19, 2023 · 2 comments
Open

Comments

@lydell
Copy link
Owner

lydell commented Sep 19, 2023

In another project, I use run-pty --auto-exit to run 5 checks.

Locally, everything (so far) works perfectly.

But in GitHub Actions, some commands can sometimes exit early with code 0, causing lint errors and suchlike not to be caught in CI.

I need to dig deeper into this. First thing is to try to reproduce it in this repo I think, that’ll make debugging much easier.

@lydell
Copy link
Owner Author

lydell commented Sep 23, 2023

This seems to be a bug in node-pty (or potentially Node.js 18.18+ and 20.3+): microsoft/node-pty#630

@lydell
Copy link
Owner Author

lydell commented Mar 19, 2024

Workaround released in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant