Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to Korean #98

Merged
merged 10 commits into from Jun 29, 2019
Merged

Translate to Korean #98

merged 10 commits into from Jun 29, 2019

Conversation

danah-kim
Copy link
Contributor

Happy to meet you,
I am a full stack engineer sweetmilkys who works in Korea.

I got to know your Question through my teacher serranoarevalo .
I think this is so awesome, so I want to introduce my country in Korean.
I translated Korean, so please merge it if you like.

Thank you :)

@Violet-Bora-Lee
Copy link

@sweetmilkys
Hi, I could help you to translate into Korean. Let's share the experiences together :)
You could have a role as a project manager for Korean to organize the project.
One of the most important things, when you are translating with many folks, is to escape duplicated tasks.
I'll wait for your response 👍 Thanks.

@Violet-Bora-Lee
Copy link

@jjoung1128
Hello :) As @sweetmilkys have made first PR for Korean, we could translate together under her management. How do you think? I'm waiting for your and her response.

@jjoung1128
Copy link

Hi @Violet-Bora-Lee , I would love to take part in Korean translation for this project. Thanks for the suggestion 👍. @sweetmilkys , please let me know which part you want me to work on when you get a chance 😃.

Copy link

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가/삭제된 라인에 대해서 설명부탁드립니다~

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@danah-kim
Copy link
Contributor Author

danah-kim commented Jun 27, 2019

@Violet-Bora-Lee, @jjoung1128
I really appreciate for your suggestion, but if I manage or what else I will feel pressure. Because I just want to people when I started this... Also I don’t think this is a task for me.
So if you don’t mind, could you let me know by the issue in my repositoriy or comment?
I hope you understand what I mean. Again Thank you!

@Violet-Bora-Lee
Copy link

@sweetmilkys @jjoung1128

안녕하세요, 저희 다 한국인인것 같아서..ㅎㅎ 한국어로 이야기 하는게 서로의 상황을 더 잘 이해할것 같네요. sweetmilkys님이 가장 먼저 Korean관련 이슈를 남겨주셔서 한국어 번역 관련 전반적인 매니징을 해주시는게 좋을 것 같아서 댓글 남겨보았습니다~

저는 sweetmilkys님이 해주셨으면 좋겠다는 마음이 들어요. 공동작업을 통해 배울수 있는 버전관리 개념들이 있는데, 회사 들어가기 전에 배워두면 좋거든요.

부담되신다면 @jjoung1128님께 중복 번역 방지 등의 PM작업을 부탁드려도 될까요?

답변기다리겠습니다 👍

@danah-kim
Copy link
Contributor Author

@Violet-Bora-Lee
위에서도 말씀드렸듯이 소소하게 하려했던거라 그렇게 되면 시간 할애를 많이 하게 될 것 같습니다.

다시한번 더 의견 주셔서 감사의 말씀을 드립니다.

@Violet-Bora-Lee
Copy link

@sweetmilkys
네 의견 감사합니다. @jjoung1128님께서도 포크떠서 작업중이시고, 저도 포크떠서 작업시작하려고 하는데, PM역할이 없으면 중복번역이 생겨서요.. @jjoung1128 님 저장소를 중심으로 해야할것 같네요. @jjoung1128 님 의견 부탁드려요.

@jjoung1128
Copy link

@Violet-Bora-Lee 님 의견 감사합니다. 저는 어떤 저장소를 쓰던 괜찮습니다. 현재 제 저장소에는 인트로 부분하고 첫번째 문제만 샘플처럼 번역되어 있는데 먼저 @sweetmilkys 님의 작업을 옮겨온뒤 나머지 부분을 나눠서 하는것이 좋을까요?

Copy link

@flynnpark flynnpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국어 버전의 README에 원본 README의 링크를 추가하면 좋을 것 같습니다.

@danah-kim
Copy link
Contributor Author

@wphestiraid
생각지도 못한 부분인데, 매우 좋은 의견 이네요! 보내주신 의견 반영했습니다.
감사합니다.

@Violet-Bora-Lee
Copy link

Violet-Bora-Lee commented Jun 27, 2019

@jjoung1128 네. 작업 진행해주시면 저도 포크 떠서 기여 하도록 하겠습니다 :) 주위에 같이 작업 하시려는 동지들이 있으신것 같은데, 번역을 시작하겠다는 이슈등록을 jjoung1128님의 저장소에서 진행하고 중복 이슈가 있으면 매니징 해주시면 될것같아요.

@lydiahallie lydiahallie merged commit 9fa18b6 into lydiahallie:master Jun 29, 2019
@lydiahallie
Copy link
Owner

Amazing! 🚀 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants