Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove key window requirement for touches #18

Merged
merged 4 commits into from Jul 22, 2021

Conversation

gabriellanata
Copy link
Contributor

@gabriellanata gabriellanata commented Jul 22, 2021

Key window is an unnecessary requirement for touches so I'm moving the check only to keyboard events. In many cases, the window will become key by itself when tapped, but we don't need to enforce that.

@gabriellanata gabriellanata requested a review from dduan July 22, 2021 09:15
@gabriellanata
Copy link
Contributor Author

👀 @dduan

@gabriellanata gabriellanata merged commit 3b72930 into main Jul 22, 2021
@gabriellanata gabriellanata deleted the Remove-key-window-requirement branch July 22, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

having trouble interacting with the callout bar
2 participants