New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: split pr for metrics protos #2246
Conversation
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
return type should be one: enable in config section example: topology uses data blob that it ingests |
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits
Description
It was requested to split this PR https://github.com/lyft/clutch/pull/2223/files to just the protos, so here they are :)
The idea here is that there will be a "metrics" service in Clutch that can get metrics from a store, such as m3 or something else. It follows a similar pattern as the
diagnostics
api in private. It could potentially "fan-out" to providers, as shown in the config proto. Something discussed at a meeting was that even though not necessarily all providers will have the same fields as prometheus does, it is ok for some of the fields to be blank.Testing Performed
none needed
GitHub Issue
Fixes #
TODOs