stats: clean up default inclusion list #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Schore <mike.schore@gmail.com>
|
Note, I'm assuming we're including all the retry stats. |
junr03
reviewed
Jul 28, 2020
| - safe_regex: | ||
| google_re2: {} | ||
| regex: 'vhost.api.vcluster\.[\w]+?\.upstream_rq_timeout' | ||
| regex: '^http.hcm.downstream_rq_(?:[12345]xx|total|completed)' |
There was a problem hiding this comment.
should total and completed be kept as exact?
There was a problem hiding this comment.
It'll still be cheaper to check the shared prefix once via the single regex.
junr03
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The previous list of stats would result in redundant checks and larger state machines. This change slims things down.
Signed-off-by: Mike Schore mike.schore@gmail.com