Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new service port to Job manager service #85

Open
rmuthupandian opened this issue Aug 22, 2019 · 3 comments
Open

Adding new service port to Job manager service #85

rmuthupandian opened this issue Aug 22, 2019 · 3 comments

Comments

@rmuthupandian
Copy link

Hi,
We are trying to expose metrics vis Prometheus reporter. We added prometheus reporter and port details to flink config. We want this port to be exposed from service. But I see only below mentioned ports exposed.

func getJobManagerPorts(app *v1beta1.FlinkApplication) []coreV1.ContainerPort {
return []coreV1.ContainerPort{
{
Name: FlinkRPCPortName,
ContainerPort: getRPCPort(app),
},
{
Name: FlinkBlobPortName,
ContainerPort: getBlobPort(app),
},
{
Name: FlinkQueryPortName,
ContainerPort: getQueryPort(app),
},
{
Name: FlinkUIPortName,
ContainerPort: getUIPort(app),
},
{
Name: FlinkInternalMetricPortName,
ContainerPort: getInternalMetricsQueryPort(app),
},

Is there a way we can add additional ports to the spec. ?

@rmuthupandian rmuthupandian changed the title Add new service port to Job manager service Adding new service port to Job manager service Aug 22, 2019
@anandswaminathan
Copy link
Contributor

@rmuthupandian

Why do you want the ports to be exposed in the Jobmanager service ? From what I understand, prometheus should be able to scrape metrics directly from the Kubernetes resources (pods) right. You simple just need to add annotations - details.

@rmuthupandian
Copy link
Author

Our internal prometheus integration depends on service port to scrape metrics. Hence we have to expose the port via service only.

@anandswaminathan
Copy link
Contributor

anandswaminathan commented Aug 23, 2019

Oh interesting, it is not possible to do that from the spec.

You will have to implement - mutating admission controller webhook on your end to accomplish that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants