Sort messages added to Github for check consistency #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To know if a message should be added to Github we check if it was already added. Or if we have more than one messages for a line, they are not guaranteed to be in the same order, so the check fail. This commit simply sort the lines before adding them to the final message to check. (It also simplifies this part of the code using the fact that `set.add` will not add a new occurence of the value if already present, so the extra set and the `if..in` are not needed)
|
This LGTM, can you rebase it @twidi and let me know when you do so I can merge? |
|
I'm currently at DjangoConEu in Firenze with poor network so I'll do it once back home. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To know if a message should be added to Github we check if it was
already added.
Or if we have more than one messages for a line, they are not guaranteed
to be in the same order, so the check fail.
This commit simply sort the lines before adding them to the final
message to check.
(It also simplifies this part of the code using the fact that
set.addwill not add a new occurence of the value if already present, so the
extra set and the
if..inare not needed)