Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

pickUsing method does not support fragments #41

Closed
mattkrebs opened this issue Apr 13, 2016 · 2 comments · Fixed by #43
Closed

pickUsing method does not support fragments #41

mattkrebs opened this issue Apr 13, 2016 · 2 comments · Fixed by #43
Assignees
Milestone

Comments

@mattkrebs
Copy link

when calling cropView.extensions() .pickUsing(this, RequestCodes.PICK_IMAGE_FROM_GALLERY); from with in a fragment returns the result to the parent activity and not back to the fragments onActivityResult Is there a work around or is this something that can be added. Thanks for the library, loving it so far.

@eveliotc
Copy link
Contributor

Thanks @mattkrebs we use scoop that's why we missed fragments ;) Adding support for fragments shouldn't be complicated, will add it for next release.

@eveliotc
Copy link
Contributor

#43 Added support for framework Fragments, if you are using support-v4 Fragments, consider using something similar to this in your code base

https://github.com/lyft/scissors/pull/43/files#diff-048c760754d3c26822798af85fdb8d6aR39

I did not want to add a dependency on support-v4 at the moment, hoping to refactor extensions as separate artifacts in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants