Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving footnotes when refactoring notes #97

Open
philou opened this issue Sep 2, 2023 · 2 comments
Open

Moving footnotes when refactoring notes #97

philou opened this issue Sep 2, 2023 · 2 comments

Comments

@philou
Copy link

philou commented Sep 2, 2023

General Description

I use footnotes a lot when I take notes. Footnotes often reside at the bottom of the note. When we extract a part of a note to a new note, it is possible that a link to a footnote is extracted while the footnote definition is not.

It would be great to move the referenced footnotes as we refactor the notes.

Example for an extract refactoring

some text, that stays in the original note
...
This is the line I am extracting to a new note[^1]
...
some more text, that also stays in the original note

[^1]: the footnote declaration

The extracted note will look like

This is the line I am extracting to a new note[^1]

It contains a dangling footnote link.

Proposition

I propose that the extracted footnote be:

This is the line I am extracting to a new note[^1]
[^1]: the footnote declaration

Nice to have

The original note could be modified to remove the unused footnotes.

Pull Request

I forked the repo and have started to work on the issue. You can have a look at a draft PR at philou#1. It's a proof of concept, just enough to get your feedback about the design and to correct any problem early.

With your advice, I would be glad to continue working on this feature

@philou
Copy link
Author

philou commented Sep 19, 2023

@lynchjames : Hi, did you have the time to check the design in my draft PR? (philou#1.)

@lynchjames
Copy link
Owner

Thanks. I've had a look and left a few comments/questions on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants