Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(a11y): sbb-navigation can be left with screenreader without closing A4A#77 #1879

Closed
kyubisation opened this issue Jul 18, 2023 · 2 comments
Closed

bug(a11y): sbb-navigation can be left with screenreader without closing A4A#77 #1879

kyubisation opened this issue Jul 18, 2023 · 2 comments
Assignees
@jeripeierSBB @dauriamarco

Comments

@kyubisation
Copy link
Contributor

The main navigation can be exited using the screen reader without closing it.
With screen readers you can use the arrow keys to reach the whole page when the navigation is open.
@kyubisation kyubisation created this issue from a note in ESTA Web Design System (sbb.ch Priority) Jul 18, 2023
@kyubisation kyubisation moved this from sbb.ch Priority to Next in ESTA Web Design System Jul 18, 2023
@kyubisation kyubisation changed the title bug: sbb-navigation can be left with screenreader without closing A4A#77 bug(a11y): sbb-navigation can be left with screenreader without closing A4A#77 Jul 18, 2023
@dauriamarco dauriamarco self-assigned this Jul 18, 2023
@jeripeierSBB
Copy link
Contributor

showModal() probably becomes usable in Webkit / Safari: WebKit/WebKit@6bad136

@dauriamarco dauriamarco removed their assignment Jul 21, 2023
@jeripeierSBB
Copy link
Contributor

Will be in Safari 17: https://developer.apple.com/documentation/safari-release-notes/safari-17-release-notes

@jeripeierSBB jeripeierSBB mentioned this issue Oct 25, 2023
Merged
jeripeierSBB added a commit that referenced this issue Oct 26, 2023
@jeripeierSBB @dauriamarco
fix(sbb-dialog, sbb-menu, sbb-navigation, sbb-tooltip): fix reading o…
6497b18 
…rder for VoiceOver with Safari (#2106)

Beside the main fix for the reading order in Safari with VoiceOver, we removed the role=group from the sbb-dialog and replaced it with a custom announcing logic. Moreover we could remove some existing workarounds and fixed a small bug in high contrast mode of the `sbb-navigation`.

Closes #2015, #1879, #1880

BREAKING CHANGE:
- The property `accessibilityLabel` of the `sbb-navigation` was removed. As replacement, an `aria-label` can now directly be placed on the `sbb-navigation` element.

---------

Co-authored-by: Marco D'Auria <marco.dauria@finconsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

@dauriamarco dauriamarco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kyubisation @jeripeierSBB @dauriamarco