Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dialog is output with incorrect role #2015

Closed
3 tasks done
Ckauczor opened this issue Sep 27, 2023 · 0 comments · Fixed by #2106
Closed
3 tasks done

[Bug]: Dialog is output with incorrect role #2015

Ckauczor opened this issue Sep 27, 2023 · 0 comments · Fixed by #2106
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@Ckauczor
Copy link

Preflight Checklist

Bug type

Accessibility

It affects the following packages

Components

Which version of Lyne Components are you using

0.40.14

Operating system

No response

Browser / Browser version

No response

Input mode

None

Additional settings

No response

What happened?

The "Travelers" dialog is output with the wrong role as "group" because the element is marked with Role="group".

The Role="group" should be removed from the element.
Unbenannt1

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. ...

Relevant log output

No response

@Ckauczor Ckauczor added the type: bug 🐛 Something isn't working label Sep 27, 2023
jeripeierSBB added a commit that referenced this issue Oct 26, 2023
…rder for VoiceOver with Safari (#2106)

Beside the main fix for the reading order in Safari with VoiceOver, we removed the role=group from the sbb-dialog and replaced it with a custom announcing logic. Moreover we could remove some existing workarounds and fixed a small bug in high contrast mode of the `sbb-navigation`.

Closes #2015, #1879, #1880

BREAKING CHANGE:
- The property `accessibilityLabel` of the `sbb-navigation` was removed. As replacement, an `aria-label` can now directly be placed on the `sbb-navigation` element.

---------

Co-authored-by: Marco D'Auria <marco.dauria@finconsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
3 participants