Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-notification): fix accessibility #2325

Merged
merged 9 commits into from
Feb 8, 2024
Merged

fix(sbb-notification): fix accessibility #2325

merged 9 commits into from
Feb 8, 2024

Conversation

dauriamarco
Copy link
Contributor

Fixes accessibility issues.

@dauriamarco dauriamarco self-assigned this Jan 9, 2024
@github-actions github-actions bot requested a deployment to preview-pr2325 January 9, 2024 16:04 In progress
jeripeierSBB
jeripeierSBB requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting into this!

src/components/notification/notification.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to preview-pr2325 January 11, 2024 11:07 In progress
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@dd38d13). Click here to learn what that means.

❗ Current head ac672d4 differs from pull request most recent head 4cdcf5a. Consider uploading reports for the commit 4cdcf5a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage        ?   93.68%           
=======================================
  Files           ?      228           
  Lines           ?    23470           
  Branches        ?     2054           
=======================================
  Hits            ?    21987           
  Misses          ?     1444           
  Partials        ?       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2325 January 15, 2024 10:00 In progress
jeripeierSBB
jeripeierSBB approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauriamarco dauriamarco force-pushed the fix/notification-accessibility branch 2 times, most recently from 9a0d2b1 to 4c2ae9c Compare January 17, 2024 09:15
@github-actions github-actions bot requested a deployment to preview-pr2325 January 17, 2024 09:39 In progress
@github-actions github-actions bot requested a deployment to preview-pr2325 January 26, 2024 09:29 In progress
@github-actions github-actions bot temporarily deployed to preview-pr2325 January 26, 2024 14:03 Inactive
@kyubisation kyubisation added the pr: lead review required A lead review is required for this pull request label Feb 5, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2325 February 8, 2024 13:02 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2325 February 8, 2024 15:36 Inactive
jeripeierSBB
jeripeierSBB approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@jeripeierSBB jeripeierSBB added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Feb 8, 2024
@dauriamarco dauriamarco merged commit 00e9540 into main Feb 8, 2024
15 checks passed
@dauriamarco dauriamarco deleted the fix/notification-accessibility branch February 8, 2024 16:04
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees

@dauriamarco dauriamarco

Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dauriamarco @codecov-commenter @kyubisation @jeripeierSBB @DavideMininni-Fincons