Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-calendar): using keyboard navigation loses focus #2354

Merged
merged 11 commits into from
Feb 8, 2024

Conversation

MarioCastigliano
Copy link
Contributor

@MarioCastigliano MarioCastigliano commented Jan 17, 2024

Preflight Checklist

Issue

This PR Closes #2300

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • Fix focus loss during keyboard navigation
  • Fix data-now="" being incorrectly interpreted as "Jan 1, 1970"

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f239990). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage        ?   93.68%           
=======================================
  Files           ?      228           
  Lines           ?    23470           
  Branches        ?     2059           
=======================================
  Hits            ?    21989           
  Misses          ?     1442           
  Partials        ?       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2354 January 23, 2024 16:12 Inactive
@kyubisation kyubisation changed the title fix(sbb-calendar): using keyboard navigation loses focus fix(sbb-calendar): using keyboard navigation loses focus [WIP] Feb 5, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 6, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 6, 2024 16:40 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 7, 2024 09:08 Inactive
@MarioCastigliano MarioCastigliano marked this pull request as draft February 7, 2024 09:17
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 7, 2024 09:25 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 7, 2024 13:14 Inactive
@MarioCastigliano MarioCastigliano marked this pull request as ready for review February 7, 2024 14:41
@MarioCastigliano MarioCastigliano changed the title fix(sbb-calendar): using keyboard navigation loses focus [WIP] fix(sbb-calendar): using keyboard navigation loses focus Feb 7, 2024
@MarioCastigliano MarioCastigliano added the pr: peer review required A peer review is required for this pull request label Feb 7, 2024
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks legit and good to me.
I just have a doubt on the .?query... thing

src/components/calendar/calendar.ts Outdated Show resolved Hide resolved
src/components/calendar/calendar.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to preview-pr2354 February 8, 2024 12:19 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioCastigliano MarioCastigliano merged commit 68be709 into main Feb 8, 2024
15 checks passed
@MarioCastigliano MarioCastigliano deleted the fix/sbb-calendar branch February 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(sbb-datepicker): using keyboard navigation loses focus
4 participants