Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): implemented a11y tree snapshot function #2378

Merged
merged 9 commits into from
Feb 1, 2024
Merged

feat(a11y): implemented a11y tree snapshot function #2378

merged 9 commits into from
Feb 1, 2024

Conversation

TomMenga
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a deployment to preview-pr2378 January 30, 2024 15:53 In progress
@github-actions github-actions bot temporarily deployed to preview-pr2378 January 30, 2024 16:01 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b3a05e3). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2378   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?      223           
  Lines           ?    23337           
  Branches        ?     2054           
=======================================
  Hits            ?    21861           
  Misses          ?     1438           
  Partials        ?       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2378 January 30, 2024 16:19 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2378 January 31, 2024 08:49 Inactive
kyubisation
kyubisation approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work!

src/components/core/dom/platform.ts Outdated Show resolved Hide resolved
src/components/selection-panel/selection-panel.spec.ts Show resolved Hide resolved
web-test-runner.config.js Show resolved Hide resolved
@TomMenga @kyubisation
chore: fix typo
15c0f48 
Co-authored-by: Lukas Spirig <lukas.spirig@sbb.ch>
@TomMenga TomMenga merged commit 3484e7b into main Feb 1, 2024
15 checks passed
@TomMenga TomMenga deleted the feat/a11y-tree branch February 1, 2024 07:53
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
@TomMenga TomMenga mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

Assignees
No one assigned
Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomMenga @codecov-commenter @kyubisation